From: Leif Lindholm <leif.lindholm@linaro.org>
To: chandni cherukuri <chandni.cherukuri@arm.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms
Date: Mon, 19 Nov 2018 12:04:52 +0000 [thread overview]
Message-ID: <20181119120452.cbaxor7typ7ndcli@bivouac.eciton.net> (raw)
In-Reply-To: <CADXzzgq+aaW1YsXZLrnGjMUGO37eoY3YY2JJJ+WbpVie8tHF7w@mail.gmail.com>
Hi Chandni,
On Mon, Nov 19, 2018 at 05:00:39PM +0530, chandni cherukuri wrote:
> On Mon, Nov 12, 2018 at 9:57 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > Hi Chadni,
> >
> > I will disregard this set.
> > Please send out a new v3 containing the changes we've discussed, only
> > after I've completed reviewing the set.
> >
> > Best Regards,
> >
> > Leif
> >
>
> Hi Leif,
>
> Can I post the new v3 patchset containing the changes that we've discussed?
I have one more comment/question that applies to a few of the ACPI
files. Last week I was at Linux Plumbers Conference with very patchy
availability, so didn't get the time.
Regards,
Leif
> Thanks
> Chandni
>
> > On Mon, Nov 12, 2018 at 05:11:51PM +0530, Chandni Cherukuri wrote:
> > > Changes since v2:
> > > - Added additional checks for platform-id and config-id values.
> > >
> > > Changes since v1:
> > > - No code changes, posting this series again with correct patch subject
> > >
> > > This patch series adds support for two new Arm's SGI platforms -
> > > SGI-Clark.Ares and SGI-Clark.Helios. The first patch in this
> > > series adds support to use a new binding added to the system-id
> > > node for Platform Identification. The rest of the patches add
> > > support for the two new SGI platforms.
> > >
> > > Chandni Cherukuri (5):
> > > Platform/ARM/Sgi: Adapt to changes in system-id DT node.
> > > Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform
> > > Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform
> > > Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform
> > > Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform
> > >
> > > Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +
> > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +
> > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/AcpiTables.inf | 58 +++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/AcpiTables.inf | 58 +++++
> > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 +
> > > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 5 +
> > > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 19 +-
> > > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 24 +-
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dbg2.aslc | 90 +++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dsdt.asl | 116 +++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Fadt.aslc | 87 +++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Gtdt.aslc | 152 +++++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Iort.aslc | 106 ++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Madt.aslc | 171 +++++++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Mcfg.aslc | 61 +++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Spcr.aslc | 77 ++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Ssdt.asl | 95 +++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Dbg2.aslc | 90 +++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Dsdt.asl | 262 +++++++++++++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Fadt.aslc | 87 +++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Gtdt.aslc | 152 +++++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Iort.aslc | 106 ++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Madt.aslc | 266 ++++++++++++++++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Mcfg.aslc | 61 +++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Spcr.aslc | 77 ++++++
> > > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Ssdt.asl | 95 +++++++
> > > 27 files changed, 2315 insertions(+), 8 deletions(-)
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/AcpiTables.inf
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/AcpiTables.inf
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dbg2.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dsdt.asl
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Fadt.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Gtdt.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Iort.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Madt.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Mcfg.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Spcr.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Ssdt.asl
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Dbg2.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Dsdt.asl
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Fadt.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Gtdt.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Iort.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Madt.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Mcfg.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Spcr.aslc
> > > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Ssdt.asl
> > >
> > > --
> > > 2.7.4
> > >
> > >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-11-19 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 11:41 [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms Chandni Cherukuri
2018-11-12 11:41 ` [PATCH v3 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node Chandni Cherukuri
2018-11-12 11:41 ` [PATCH v3 edk2-platforms 2/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform Chandni Cherukuri
2018-11-19 15:35 ` Leif Lindholm
2018-11-12 11:41 ` [PATCH v3 edk2-platforms 3/5] Platform/ARM/Sgi: Add initial support " Chandni Cherukuri
2018-11-19 15:13 ` Leif Lindholm
2018-11-12 11:41 ` [PATCH v3 edk2-platforms 4/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform Chandni Cherukuri
2018-11-19 16:30 ` Leif Lindholm
2018-11-12 11:41 ` [PATCH v3 edk2-platforms 5/5] Platform/ARM/Sgi: Add initial support " Chandni Cherukuri
2018-11-19 16:34 ` Leif Lindholm
2018-11-12 16:27 ` [PATCH v3 edk2-platforms 0/5] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms Leif Lindholm
2018-11-19 11:30 ` chandni cherukuri
2018-11-19 12:04 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119120452.cbaxor7typ7ndcli@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox