Re: [PATCH v3 edk2-platforms 3/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform

[Leif Lindholm <leif.lindholm@linaro.org>]

On Mon, Nov 12, 2018 at 05:11:54PM +0530, Chandni Cherukuri wrote:
> Add the initial support for ARM's System Guidance for Infrastructure
> SGI-Clark.Ares platform. The ACPI tables for this platform are
> installed.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
> ---
>  Platform/ARM/SgiPkg/Include/SgiPlatform.h             |  4 ++++
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 16 +++++++++-------
>  2 files changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> index 1454018..b84709e 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> @@ -72,6 +72,10 @@
>  #define SGI575_CONF_NUM                           0x3
>  #define SGI575_PART_NUM                           0x783
>  
> +//SGI-Clark Platform Identification values
> +#define SGI_CLARK_PART_NUM                        0x786
> +#define SGI_CLARKA_CONF_NUM                       0x1

I would prefer for this to be SGI_CLARK_CONF_NUM_A (assuming, of
course, this refers to "configuration A"). With that change:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

/
    Leif

> +
>  #define SGI_CONFIG_MASK                           0x0F
>  #define SGI_CONFIG_SHIFT                          0x1C
>  #define SGI_PART_NUM_MASK                         0xFFF
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> index 5ccd01d..1c56f65 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> @@ -48,14 +48,16 @@ ArmSgiPkgEntryPoint (
>  
>    if ((PartNum == SGI575_PART_NUM) && (ConfigId == SGI575_CONF_NUM)) {
>      Status = LocateAndInstallAcpiFromFv (&gSgi575AcpiTablesFileGuid);
> -    if (EFI_ERROR (Status)) {
> -      DEBUG ((DEBUG_ERROR, "%a: Failed to install ACPI tables\n",
> -        __FUNCTION__));
> -      return Status;
> -    }
> +  } else if ((PartNum == SGI_CLARK_PART_NUM) &&
> +             (ConfigId == SGI_CLARKA_CONF_NUM)) {
> +    Status = LocateAndInstallAcpiFromFv (&gSgiClarkAresAcpiTablesFileGuid);
>    } else {
> -    DEBUG ((DEBUG_ERROR, "PlatformDxe: Unsupported Platform Id\n"));
> -    return EFI_UNSUPPORTED;
> +    Status = EFI_UNSUPPORTED;
> +  }
> +
> +  if (EFI_ERROR (Status)) {
> +    DEBUG ((DEBUG_ERROR, "%a: Failed to install ACPI tables\n", __FUNCTION__));
> +    return Status;
>    }
>  
>    Status = EFI_REQUEST_UNLOAD_IMAGE;
> -- 
> 2.7.4
>