From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9EB6021A07A80 for ; Mon, 19 Nov 2018 07:13:04 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id j2so4095442wrw.1 for ; Mon, 19 Nov 2018 07:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=L1XtGvD6DXGras7ODyHsPEfUICwxoAJgDPUykWVPPeA=; b=glOJyGMK3PmT8dMLA5nI49m47HIB5TKHDXu49tv7EEOlLKsHhk6+pQ3mHMU6F3JQ3l LjsjpmhHHaCxRBLDd+GzW1CNjG2IbJJVoIJlmsngFBlU1ISNdZRbcIH0zUxrfZdYfgG8 45B5fIm2fe+Jgjqeqqk1D1EENWdu9xlCJdUxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L1XtGvD6DXGras7ODyHsPEfUICwxoAJgDPUykWVPPeA=; b=S7elpaJWyHcQvtI8nO3Op8WBM45VcOoaM3oSNvDfdf8+qHscp2wF1goOK0PxJQ8qnD Y/L6n7lw+HW7pVur1qITwryE21tlZ/10AWumsa+gHexRhn6li5LcBD5pAy1lJKJocIk5 CO9UAYm9e+ZP2DozbX/qX7fBR9ffVfDlberdsMgkOUPcmchRe4ZukdsgIoV6SuM7FPVp eQ2d3VFxSz6f9RuZhCEsoRN2VcxZR39J8W3egnKawaAxP+e3j/+GJOPZFsMC2intx188 iE0RJb/Cgva3K9NzHYxR3zoI589OmQwj/tC5gld/IHFTSLbpzP1Y0tt/wkgzvLSoeOSU 729g== X-Gm-Message-State: AGRZ1gI8gMXy2GauoiRdVkfjoVJXhcxhB+Id2EWjxvVOT1iSdbEtrwQF HSBVJJR3YqOIh3gipfLrHNWvrQ== X-Google-Smtp-Source: AJdET5cl5jGIPUEYwdzEbBJpFlYXEpAUTBL5SGxasampHkDUiH6BTAlxmd2T6hiXQoYHghMtTKHzQQ== X-Received: by 2002:adf:ce86:: with SMTP id r6mr19358593wrn.257.1542640382695; Mon, 19 Nov 2018 07:13:02 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z6-v6sm38175599wrs.19.2018.11.19.07.13.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 07:13:01 -0800 (PST) Date: Mon, 19 Nov 2018 15:13:00 +0000 From: Leif Lindholm To: Chandni Cherukuri Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20181119151300.ghx4zpu4d4exp6uu@bivouac.eciton.net> References: <1542022916-24462-1-git-send-email-chandni.cherukuri@arm.com> <1542022916-24462-4-git-send-email-chandni.cherukuri@arm.com> MIME-Version: 1.0 In-Reply-To: <1542022916-24462-4-git-send-email-chandni.cherukuri@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 edk2-platforms 3/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 15:13:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 12, 2018 at 05:11:54PM +0530, Chandni Cherukuri wrote: > Add the initial support for ARM's System Guidance for Infrastructure > SGI-Clark.Ares platform. The ACPI tables for this platform are > installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Chandni Cherukuri > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 4 ++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 16 +++++++++------- > 2 files changed, 13 insertions(+), 7 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index 1454018..b84709e 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -72,6 +72,10 @@ > #define SGI575_CONF_NUM 0x3 > #define SGI575_PART_NUM 0x783 > > +//SGI-Clark Platform Identification values > +#define SGI_CLARK_PART_NUM 0x786 > +#define SGI_CLARKA_CONF_NUM 0x1 I would prefer for this to be SGI_CLARK_CONF_NUM_A (assuming, of course, this refers to "configuration A"). With that change: Reviewed-by: Leif Lindholm / Leif > + > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > #define SGI_PART_NUM_MASK 0xFFF > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > index 5ccd01d..1c56f65 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -48,14 +48,16 @@ ArmSgiPkgEntryPoint ( > > if ((PartNum == SGI575_PART_NUM) && (ConfigId == SGI575_CONF_NUM)) { > Status = LocateAndInstallAcpiFromFv (&gSgi575AcpiTablesFileGuid); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Failed to install ACPI tables\n", > - __FUNCTION__)); > - return Status; > - } > + } else if ((PartNum == SGI_CLARK_PART_NUM) && > + (ConfigId == SGI_CLARKA_CONF_NUM)) { > + Status = LocateAndInstallAcpiFromFv (&gSgiClarkAresAcpiTablesFileGuid); > } else { > - DEBUG ((DEBUG_ERROR, "PlatformDxe: Unsupported Platform Id\n")); > - return EFI_UNSUPPORTED; > + Status = EFI_UNSUPPORTED; > + } > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Failed to install ACPI tables\n", __FUNCTION__)); > + return Status; > } > > Status = EFI_REQUEST_UNLOAD_IMAGE; > -- > 2.7.4 >