From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 238B42118FF2E for ; Mon, 19 Nov 2018 07:35:08 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id p4so23381698wrt.7 for ; Mon, 19 Nov 2018 07:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w5p8PSazl2IngZxOesWM91Ok301JupST9dUbYSkUzf8=; b=BygViCWbmYJOitFkaXIcsWhKb4PNmqp1/xhb8Us2RIQ7OqFAz0Egqj2mRTqkzk2PYI JCVt4d5ckJZkecklHc5k6pzzBEgYQi7BjfCH0yRqSpbBcJFBLsnHh3VGpYs7MoU7GMcP Dcx9u+MZPGlSFszTTZBjpyW1LzU5nPREjl1yE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w5p8PSazl2IngZxOesWM91Ok301JupST9dUbYSkUzf8=; b=nH8jvDpMGi+QH2O0rMZaApDBVmjzrZw1LLAuJTLzlo9KGdEMvnxrBNlyK7prNPX2p3 IcczYFChk1wfnSDMLxvF1h7s7VfejD5KWxWpr/P6xSXqFiXAib0+zTKmcSpv2xwJdDpv cyfoiFZ1kXvrAV5IfuEJsdyDOSpn7zEEIJ5BQbTayu9/SgzpadanP4oimuYrTeiwxLfr 7THo55CJY//daHRv/dR1u+us/y4Zp1wAP3IGhDK3hoes8MN6WEWfkhWRAWOv6Gx+eF0s jZoMgSgeqkntgaQ1EP7zWVerLoa9mDj2rJUUgAyOS9LxYtGanC1tdmMXPjtBKSF/IEkK 2YRg== X-Gm-Message-State: AGRZ1gIKhr5mR02/vvtUd9m8oR32APtJdPg2/8uFDp8m97JdsFM/6Iqu DUD9WIl6bQsjQN+nngL8v/YCdSsU+9c= X-Google-Smtp-Source: AJdET5ezDK+F434682TvFiuP+QE0N3pzzSjegTB+rN1bky4quhO6Oa3ZQ2F7R0CCggfqWgdrBu1anQ== X-Received: by 2002:a5d:4acb:: with SMTP id y11mr18354547wrs.281.1542641706377; Mon, 19 Nov 2018 07:35:06 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j19sm14230551wmj.44.2018.11.19.07.35.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 07:35:05 -0800 (PST) Date: Mon, 19 Nov 2018 15:35:03 +0000 From: Leif Lindholm To: Chandni Cherukuri Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20181119153503.o632uuf56wkwfkbe@bivouac.eciton.net> References: <1542022916-24462-1-git-send-email-chandni.cherukuri@arm.com> <1542022916-24462-3-git-send-email-chandni.cherukuri@arm.com> MIME-Version: 1.0 In-Reply-To: <1542022916-24462-3-git-send-email-chandni.cherukuri@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 edk2-platforms 2/5] Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 15:35:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 12, 2018 at 05:11:53PM +0530, Chandni Cherukuri wrote: > Added ACPI tables and GUID name 'gSgiClarkAresAcpiTablesFileGuid' > for SGI-Clark.Ares platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Chandni Cherukuri > --- > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/AcpiTables.inf | 58 +++++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dbg2.aslc | 90 +++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dsdt.asl | 116 +++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Fadt.aslc | 87 ++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Gtdt.aslc | 152 +++++++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Iort.aslc | 106 ++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Madt.aslc | 171 ++++++++++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Mcfg.aslc | 61 +++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Spcr.aslc | 77 +++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Ssdt.asl | 95 +++++++++++ Again, if SgiClarkA is a configuration, I would prefer the configuration as a subdirectory, not merged with the platform name. But I would also add that I would hope the intent is not to duplicate everything into a separate "B" directory if/when a new configuration turns up? Surely 98% of the content would remain unchanged. If so, can we just drop the A from the directory name? > 14 files changed, 1017 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dbg2.aslc b/Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dbg2.aslc > new file mode 100644 > index 0000000..3970461 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/AcpiTables/SgiClarkA/Dbg2.aslc > @@ -0,0 +1,90 @@ > +/** @file > +* Debug Port Table 2 (DBG2) > +* > +* Copyright (c) 2018, ARM Limited. All rights reserved. > +* > +* This program and the accompanying materials are licensed and made available > +* under the terms and conditions of the BSD License which accompanies this > +* distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#include "SgiAcpiHeader.h" > +#include > +#include > +#include > + > +#define SGI_DBG2_NUM_DEBUG_PORTS 1 > +#define SGI_DBG2_NUM_GAS 1 > +#define SGI_DBG2_NS_STR_LENGTH 8 > +#define SGI_PL011_REGISTER_SPACE 0x1000 > + > +#define NAME_STR_UART1 {'C', 'O', 'M', '1', '\0', '\0', '\0', '\0'} Here was the thing I was referring to earlier today: Is this used the same as what is now being fixed in https://lists.01.org/pipermail/edk2-devel/2018-November/032523.html ? If so, please update here and get it right from the start. / Leif