Re: [PATCH v3 edk2-platforms 5/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform

[Leif Lindholm <leif.lindholm@linaro.org>]

On Mon, Nov 12, 2018 at 05:11:56PM +0530, Chandni Cherukuri wrote:
> Add the initial support for ARM's System Guidance for Infrastructure
> SGI-Clark.Helios platform. The ACPI tables for this platform are
> installed.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
> ---
>  Platform/ARM/SgiPkg/Include/SgiPlatform.h             | 1 +
>  Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> index b84709e..7b0bb4a 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> @@ -75,6 +75,7 @@
>  //SGI-Clark Platform Identification values
>  #define SGI_CLARK_PART_NUM                        0x786
>  #define SGI_CLARKA_CONF_NUM                       0x1
> +#define SGI_CLARKH_CONF_NUM                       0x2

So, this one should be
 SGI_CLARK_CONF_NUM_HELIOS
_or_
 SGI_CLARK_CONF_HELIOS
.

And SGI_CLARKA_CONF_NUM should be
 SGI_CLARK_CONF_NUM_ARES
_or_
 SGI_CLARK_CONF_ARES
.

/
    Leif

>  
>  #define SGI_CONFIG_MASK                           0x0F
>  #define SGI_CONFIG_SHIFT                          0x1C
> diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> index 1c56f65..cf085f8 100644
> --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
> @@ -51,6 +51,9 @@ ArmSgiPkgEntryPoint (
>    } else if ((PartNum == SGI_CLARK_PART_NUM) &&
>               (ConfigId == SGI_CLARKA_CONF_NUM)) {
>      Status = LocateAndInstallAcpiFromFv (&gSgiClarkAresAcpiTablesFileGuid);
> +  } else if ((PartNum == SGI_CLARK_PART_NUM) &&
> +             (ConfigId == SGI_CLARKH_CONF_NUM)) {
> +    Status = LocateAndInstallAcpiFromFv (&gSgiClarkHeliosAcpiTablesFileGuid);
>    } else {
>      Status = EFI_UNSUPPORTED;
>    }
> -- 
> 2.7.4
>