From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1B8C21A00AE6 for ; Mon, 19 Nov 2018 08:34:41 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id e3-v6so32787152wrs.5 for ; Mon, 19 Nov 2018 08:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dPZVT0NePMU8pujWYHp7luN4xJJxu/jw+JmJ8TVqK2w=; b=PzKgdp22K+dO7sc6lhQdMGe1gQEY4zKvVWmQZsp+RjDXRpEK+0zxjycczn6Z/EjnHY QY4UCR3owGoN9vLtWktBV5DTE8WuIlsXQnAlzCJoeSj7tdxKBxm/QtYYuXrryiNp0nZh Bp90bSBjV7BfKPwfdtz0ZSPgOby7BG+65AfeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dPZVT0NePMU8pujWYHp7luN4xJJxu/jw+JmJ8TVqK2w=; b=mbZ9DaeOKlVcQf7Tgbz8nKzat/bpTScDzSDNfHOWKOYGg27dwRKlX1f2wSzzyJv5uy 1j/PQH0vzqbEu/E/OAPW+tBeMVOHLdZ9I28/NDEk8MMtEg4jgtzWGePJvPWMXSPv8dJ9 rTHI2cyyKYG/A9kiOsJ4h50AfSvHUGd93ZajZ5MX8wjj3639Ei+dgN9NWByU+zbWhGO+ vgA7UAbD3LBxotKTDirPHti5w9T1y22jSABJraFjhRhjG5uilG4bGlAlUlhPlT4lKL1j XXCcJy1WzqicJA4CroVDYAoETpqIT2CU1zc3CRFbMPTHMFrQgyUai9QcZHrbIWfghkCb 3nXw== X-Gm-Message-State: AGRZ1gLaziRGCZXoKBMNvTK1pOjerv+EQlyVvIdDz7d5Lkx2nBShR5XI RyjdhtV/5fcv52E2Rdxs3vIXSg== X-Google-Smtp-Source: AJdET5dBuoSmKMTEbaK5vgttEg0PHfRkOe0BMKk+Ic1YW3TyBUoLSZW3EnVouy6PXayKZrJqAho5hw== X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr17815618wri.77.1542645280114; Mon, 19 Nov 2018 08:34:40 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o15sm21598814wrp.12.2018.11.19.08.34.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 08:34:39 -0800 (PST) Date: Mon, 19 Nov 2018 16:34:37 +0000 From: Leif Lindholm To: Chandni Cherukuri Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20181119163437.vyd2u3cjyuaea5c2@bivouac.eciton.net> References: <1542022916-24462-1-git-send-email-chandni.cherukuri@arm.com> <1542022916-24462-6-git-send-email-chandni.cherukuri@arm.com> MIME-Version: 1.0 In-Reply-To: <1542022916-24462-6-git-send-email-chandni.cherukuri@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 edk2-platforms 5/5] Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 16:34:42 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 12, 2018 at 05:11:56PM +0530, Chandni Cherukuri wrote: > Add the initial support for ARM's System Guidance for Infrastructure > SGI-Clark.Helios platform. The ACPI tables for this platform are > installed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Chandni Cherukuri > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 1 + > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index b84709e..7b0bb4a 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -75,6 +75,7 @@ > //SGI-Clark Platform Identification values > #define SGI_CLARK_PART_NUM 0x786 > #define SGI_CLARKA_CONF_NUM 0x1 > +#define SGI_CLARKH_CONF_NUM 0x2 So, this one should be SGI_CLARK_CONF_NUM_HELIOS _or_ SGI_CLARK_CONF_HELIOS . And SGI_CLARKA_CONF_NUM should be SGI_CLARK_CONF_NUM_ARES _or_ SGI_CLARK_CONF_ARES . / Leif > > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > index 1c56f65..cf085f8 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -51,6 +51,9 @@ ArmSgiPkgEntryPoint ( > } else if ((PartNum == SGI_CLARK_PART_NUM) && > (ConfigId == SGI_CLARKA_CONF_NUM)) { > Status = LocateAndInstallAcpiFromFv (&gSgiClarkAresAcpiTablesFileGuid); > + } else if ((PartNum == SGI_CLARK_PART_NUM) && > + (ConfigId == SGI_CLARKH_CONF_NUM)) { > + Status = LocateAndInstallAcpiFromFv (&gSgiClarkHeliosAcpiTablesFileGuid); > } else { > Status = EFI_UNSUPPORTED; > } > -- > 2.7.4 >