From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BBD3F21191F46 for ; Mon, 19 Nov 2018 10:20:25 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id x10so4468770wrs.8 for ; Mon, 19 Nov 2018 10:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q8IXS/VpvVrx24j2k04SEztI+dkMAVj+9DEevCUtw2k=; b=AG8QnWDHo5QNUPWrfOvwzhrhuWODIBYZqmoPmIsQbuSHC2Hz27LsrT0jgBqPVR1n9L K2m7JdhS7mE1zliQACwLbTq8SHFGh8zhzkLH8yTB43v4EHgUAgm/sELmj0FBPeHmtfqj A3ADBCbVpIj2dBlWH/RwS2hsd+d981sj09/js= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q8IXS/VpvVrx24j2k04SEztI+dkMAVj+9DEevCUtw2k=; b=SzOoItwP2HeePa1fODhDfyT7+EODzWshU+CxTCaCC2cq6ii9I9emkcp1YTuFLKlrw4 1qLn2y6+Yvdn0GNyJQ1lczlRJ2+/bu+HWQga4wQunHyHPodKtQhy1JQOss1gdUztyFRF GKafDxlPd0lM0mkZhwd13OBOVW3ngxZmCSwrAZoalh2L6CAkA4E9OqumMd0tLe/8qQ11 zFrWDtlqN16XPZLcpR7/PfbyV51k5jphNU+IDCr7l5KHhx6+PUvJDMLSS9sxxhH/ctEO XxuDIqhJrwB7aCukfefQz6FnCn45qDO7VSn45fXeuekxV7WYwGtUUNf509KsqlioCMxu dB1w== X-Gm-Message-State: AA+aEWbCMNyOJFyo3ahxyeXu7vmYjaUF0GsvT8qbuu0MTN5zTQKipYQx n7Kmybl+s0eVRyvz30lsyzKmvw== X-Google-Smtp-Source: AFSGD/U/SQpC1YMpv/pJykGtR2KrtZbrz3rm40RqFNDh+0ynGNFoK/uPhOdGO7YlXfPKd+8gXH6dtA== X-Received: by 2002:a05:6000:1c8:: with SMTP id t8mr6027984wrx.146.1542651624033; Mon, 19 Nov 2018 10:20:24 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g8-v6sm45986305wri.58.2018.11.19.10.20.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 10:20:22 -0800 (PST) Date: Mon, 19 Nov 2018 18:20:21 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20181119182021.7o4o6wvd25tpava3@bivouac.eciton.net> References: <20181116065702.30559-1-ming.huang@linaro.org> <20181116065702.30559-11-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181116065702.30559-11-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 10/15] Hisilicon/D06: Modify Gic base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 18:20:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline You said in reply to my comment on v1: --- The PcdGicInterruptInterfaceBase(0xFE000000) is wrong, it just copy from D05/D03, maybe somewhere will need the right value of Pcd. --- Please split that out as a separate change, with the above mentioned in the commit message. But if I understand correctly, the remainder of the patch will be incorrect until the other changes to book from TA have been applied (in the subsequent patch). So please move the MADT change to the other patch. / Leif On Fri, Nov 16, 2018 at 02:56:57PM +0800, Ming Huang wrote: > The values of PcdGicInterruptInterfaceBase and GICD are wrong, so modify it. > Fix SBSA test case 21: > 21 : Check GIC version > GIC version is 0 > Failed on PE - 0 for Level= 3 : Result: --FAIL-- 2 > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.dsc | 2 +- > Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index b6ef9fedf0a7..ac35564f4ac6 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -183,7 +183,7 @@ [PcdsFixedAtBuild.common] > gHisiTokenSpaceGuid.PcdArmPrimaryCoreTemp|0x80010000 > gArmTokenSpaceGuid.PcdGicDistributorBase|0xAE000000 > gArmTokenSpaceGuid.PcdGicRedistributorsBase|0xAE100000 > - gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000 > + gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x9B000000 > > > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc > index 43b43142aff4..d3de69a3ef6c 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc > +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc > @@ -361,7 +361,7 @@ EFI_ACPI_MULTIPLE_APIC_DESCRIPTION_TABLE Madt = { > 0x0, 0x0, 25, 0x4000AA000000 + 0x6C0000 /* GicRBase */, 0), > }, > > - EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAA000000, 0, 0x4), > + EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAE000000, 0, 0x4), > { > EFI_ACPI_6_1_GIC_ITS_INIT(0,0x202100000), //peri a > // EFI_ACPI_6_1_GIC_ITS_INIT(1,0x400202100000), //peri a > -- > 2.9.5 >