Re: [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Nov 16, 2018 at 02:55:56PM -0800, Ard Biesheuvel wrote:
> The backtrace code on AARCH64 does not sanitize the frame pointer values
> it pulls of the stack when attempting to do a backtrace, and so junk left
> in the frame pointer register may result in a recursive exception and a
> truncated backtrace.

If I was bikeshedding, I'd ask for a (NULL) in the comments next to
the 0x0. But other than that, for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
(be it green or black)

> Ard Biesheuvel (2):
>   ArmPlatformPkg: clear frame pointer in startup code
>   ArmVirtPkg/PrePi: clear frame pointer in startup code
> 
>  ArmPlatformPkg/PrePeiCore/AArch64/PrePeiCoreEntryPoint.S | 3 +++
>  ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S          | 3 +++
>  ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S              | 3 +++
>  3 files changed, 9 insertions(+)
> 
> -- 
> 2.17.1
>