From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A33B21A09130 for ; Mon, 19 Nov 2018 10:56:32 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id g131so6008862wmg.3 for ; Mon, 19 Nov 2018 10:56:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=83z1zP8D9+3x+03xRTwsijO/v91WvhQbBu2L5Aa+3Vs=; b=JBeGL98TBmyLH/uIQKlr+oRFcygAlC86TIhaMrfXoG8vm2na1mtoGSaRZywIKPIuLN BXVeaiiXe8lNK69Ao9OpOKA5LvzfqGkzn5JphYg71PZCBSo/AZA6Q7JtYGf+Dr6SbUgY rUgkspnmcriD5u9X1+kwcU3H95TVGmPs1vDU4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=83z1zP8D9+3x+03xRTwsijO/v91WvhQbBu2L5Aa+3Vs=; b=el30vsRg3l3I6eRV++Dzg7GwsrdxKy9wtyT6mMKhOmGXEhtEe68oEpjm2lCjViPIiG YeXcMu63+Cjft6/Va6uNWEP7JXYtZBHNNA6EeGeyOuwvp5GOe1Se+DlSvE4fIChM/Dix sSQ8wgQfhL9bSyWW+5zrwRICUCOVPlkMNgU2FCl9mmo8feVV4OFM15A0XfFzPXM49Xc1 hSWDMekV81s3ybWjaM/zQ8zWXQbDAdH9CkwvRh4I6TKMWeptYDKMg1fv9T2+4RkQTb2d bkwOea3aJ/kr6BV35oU7JIvcLzKvg8+nCx5ppz//g6/uf4/RyoHM3kUZ2OGBx9CZJUj1 NO1w== X-Gm-Message-State: AA+aEWZOIlpaEdv1+QJegvBWx+t1v2ibDot/cwsp1cW3ESl7enKy68Ix 4mTGRxuTJY9I6+RcZYXFkuGlNMQ+pRU= X-Google-Smtp-Source: AJdET5cwReyZcIjCsE8+OLr8QwX928D4PWQ2Udv8idbx8EXuxPNlOyNUi9YqexqFH67DYVTSak34yA== X-Received: by 2002:a1c:a5c8:: with SMTP id o191mr7070624wme.150.1542653791486; Mon, 19 Nov 2018 10:56:31 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p6sm33213009wrx.39.2018.11.19.10.56.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 10:56:30 -0800 (PST) Date: Mon, 19 Nov 2018 18:56:29 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com, philmd@redhat.com Message-ID: <20181119185629.lhpqadyzfrffnc5p@bivouac.eciton.net> References: <20181116225558.27720-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181116225558.27720-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 18:56:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 16, 2018 at 02:55:56PM -0800, Ard Biesheuvel wrote: > The backtrace code on AARCH64 does not sanitize the frame pointer values > it pulls of the stack when attempting to do a backtrace, and so junk left > in the frame pointer register may result in a recursive exception and a > truncated backtrace. If I was bikeshedding, I'd ask for a (NULL) in the comments next to the 0x0. But other than that, for the series: Reviewed-by: Leif Lindholm (be it green or black) > Ard Biesheuvel (2): > ArmPlatformPkg: clear frame pointer in startup code > ArmVirtPkg/PrePi: clear frame pointer in startup code > > ArmPlatformPkg/PrePeiCore/AArch64/PrePeiCoreEntryPoint.S | 3 +++ > ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S | 3 +++ > ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S | 3 +++ > 3 files changed, 9 insertions(+) > > -- > 2.17.1 >