From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC1D121193076 for ; Mon, 19 Nov 2018 11:12:51 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id j17-v6so33233851wrq.11 for ; Mon, 19 Nov 2018 11:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9Z/Iw5vNTU5RJ1c/aYfHkp7CtMK1meNV3YEaaE4fEpE=; b=FOt6O1N/a2TrbRIq4MMJkF/LuPtYlVqCsl0R1OF2oXyqYOnealbUW8f9aPI6Gsyfxj erXxHiTgik0sGD3iYXDNst7nN/olfgQ8MkBgG0VFC7eUkaotgx+k8T0ytgBk/6if4pmF 2r5hGlq8XOVjZ1Tmp2y5Jw2erCOZSzU6QslEs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9Z/Iw5vNTU5RJ1c/aYfHkp7CtMK1meNV3YEaaE4fEpE=; b=Lu/UCBqicRX2EYwv2G7eWeLbDXapvCDlw6Ji4lAtpyVpMcyBLmyxU3CkFsthP48SQq 1RdDkzMeFcb5g5QELgmOxVIYyYjAyQLhbbx2yksBSEbwYzZ6SNubFaDwDkDWMdFVO8/e vTEcKLNrEaqe7+6PdJv4znOOPIa7T2jQzqK5t0XYJzkDTVoHQ1ybrJkMQd/sAaEar7Ur daamcrnAns+lPeOuLzPH+TQkGHpRd4fpgJB6hm7bQn1zh7SE6oFESwZ2xaBpKKG+8AiV MB2XAkKws7peOS7kZyakbR4yEdn5P9hPhOyKpd/tuZFiQ1u3ezFR7MzNhMYd6mTk2nVQ 1cMA== X-Gm-Message-State: AGRZ1gJtbcGU8gpPIjT0kav/s3J0bD9C7Gry6Oo3YnA79w/PwNmywdRp EMHLk689ILG0I7g8KQ8+tusMmQ== X-Google-Smtp-Source: AJdET5dXkuuY/NIltE8PHn14b2afVyUdxyaPN8Syt470JCHHn1a+kldwyydOAAO07Z5Raz3MXLf7qQ== X-Received: by 2002:adf:9589:: with SMTP id p9-v6mr18568595wrp.270.1542654770037; Mon, 19 Nov 2018 11:12:50 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b129sm14766440wmd.24.2018.11.19.11.12.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 11:12:49 -0800 (PST) Date: Mon, 19 Nov 2018 19:12:47 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Nariman Poushin , Thomas Panakamattam Abraham Message-ID: <20181119191247.5jw5yuz2y5dicfbo@bivouac.eciton.net> References: <20181117012308.32680-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181117012308.32680-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 19:12:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 16, 2018 at 05:23:08PM -0800, Ard Biesheuvel wrote: > The ArmPlatformPkg NOR flash driver has been updated to use device paths > consisting of a fixed GUID and a numeric index rather than a separate GUID > for each flash bank on a given system. This means all explicit device path > references to NOR flash banks have to be brought up to date as well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel This looks good to me, but I'd like a comment from Thomas/Nariman. With that: Reviewed-by: Leif Lindholm > --- > Platform/ARM/JunoPkg/ArmJuno.dec | 2 +- > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dec b/Platform/ARM/JunoPkg/ArmJuno.dec > index edbbb827ad45..c511796d8913 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dec > +++ b/Platform/ARM/JunoPkg/ArmJuno.dec > @@ -44,7 +44,7 @@ > gArmJunoTokenSpaceGuid.PcdSynopsysUsbEhciBaseAddress|0x7FFC0000|UINT32|0x00000005 > > # Juno Device Trees are loaded from NOR Flash > - gArmJunoTokenSpaceGuid.PcdJunoFdtDevicePath|L"VenHw(E7223039-5836-41E1-B542-D7EC736C5E59)/board.dtb"|VOID*|0x00000008 > + gArmJunoTokenSpaceGuid.PcdJunoFdtDevicePath|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)/board.dtb"|VOID*|0x00000008 > > # MHU Register base used by SCMI Mailbox transport > gArmJunoTokenSpaceGuid.PcdArmMtlDoorBell|0x2B1F0000|UINT64|0x00000024 > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index ac3d63bd4d39..55b9d64d3deb 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -176,7 +176,7 @@ > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > > # List of Device Paths that support BootMonFs > - gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(E7223039-5836-41E1-B542-D7EC736C5E59)" > + gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)" > > # > # ARM Architectural Timer Frequency > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc > index 3f0ca9872e79..06d866d6dc30 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc > @@ -163,7 +163,7 @@ > gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x1C170000 > > # List of Device Paths that support BootMonFs > - gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(E7223039-5836-41E1-B542-D7EC736C5E59)" > + gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)" > > # ARM OS Loader > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index 0542808f7d0c..3a3b4e3dbbc8 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -172,7 +172,7 @@ > # > # Define the device path to the FDT for the platform > # > - gFdtPlatformDxeTokenSpaceGuid.PcdFdtDevicePaths|L"VenHw(E7223039-5836-41E1-B542-D7EC736C5E59)/ca15a7" > + gFdtPlatformDxeTokenSpaceGuid.PcdFdtDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00)/ca15a7" > > # > # ARM Architectural Timer Frequency > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index 752e525c3469..713c5637b074 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -355,7 +355,7 @@ > # > > # List of Device Paths that support BootMonFs > - gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(E7223039-5836-41E1-B542-D7EC736C5E59);VenHw(1F15DA3C-37FF-4070-B471-BB4AF12A724A)" > + gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,00);VenHw(93E34C7E-B50E-11DF-9223-2443DFD72085,02)" > > # RunAxf support via Dynamic Shell Command protocol > # We want to use the Shell Libraries but don't want it to initialise > -- > 2.17.1 >