Re: [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

[Leif Lindholm <leif.lindholm@linaro.org>]

On Mon, Nov 19, 2018 at 11:27:22AM -0800, Ard Biesheuvel wrote:
> > > > > > In this case, NorFlashQemuLib should not expose the first flash bank
> > > > > > at all.
> > > > > >
> > > > > > To prevent introducing too much internal knowledge about which flash
> > > > > > bank is accessible under which circumstances, let's switch to using
> > > > > > the DTB to decide which flash banks to expose to the NOR flash driver.
> > > >
> > > > Does this mean we as a side effect get rid of the limitation that the
> > > > pflash image needs to be exactly 64MB. Or does that require further
> > > > changes on the QEMU side?
> > >
> > > No that is a QEMU thing.
> >
> > OK, thanks for confirming.
> > But this should mean that we don't need any changes on the guest sides
> > if/when we do fix this in QEMU?
> 
> This would indeed get rid of any discrepancies between what QEMU
> exposes and what the firmware assumes, so yes, it's an improvement in
> that sense. However, I don't think the QEMU side of this is likely to
> change any time soon.

Sure. But it does decrease the amount of reward delay required for
someone to consider having a look at it :)

Thanks!

/
    Leif