From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E558221A02937 for ; Tue, 20 Nov 2018 02:38:51 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id p4so1395287wrt.7 for ; Tue, 20 Nov 2018 02:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n48i7pkVDFiYAX2+Ps7hBTj+4G2aSFA8KSeCEq8mD6k=; b=FhSOm1qmu22/jIfoLZiss43qVRx8w8OdbNDQeozHL8IaK8vlYGTgC+f4/I71Ghzi6s 4pdDhCEpwgdrcSNWZobIEewpcJrx7QiDMUQuCiy7cWI4FD+yAzle5Gu+tOVhVFg5N4Iw +zrg0AUVlnV7212zKe3PKg0VaIEjUW5nc3EFw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n48i7pkVDFiYAX2+Ps7hBTj+4G2aSFA8KSeCEq8mD6k=; b=r3Xcs9VYSmjlx/aYkIydrdltejvP9EnfETtQYohhI6SP6S/HpoY1xqNsXnA8QH/3RD m3Xy2tUvE5smBQQcmjoLSNeAvRPV6YWBHGSSuYMpMh65zm6wuLBHuIDP4AcoPSmARI+5 1fR5Y4TCQf3SQRwEM9WbzoHpzYy32QyWCZaHtyWcFuTjP4DZ9LLMf8BoIgj0DQYCrWTR W2e6akrSs25vKHa1xVnv4HftsJ3pZhanv0iqQxzpIp7Ik3xURZaaNSZG3QmFtGhglfHS dHH2mT5wvLX2irT7ItCrdGiYwfAcmhd7vTtHDjN5CnKCsoMoqpPLwvp/RGU4Xxi62nNr 8JfA== X-Gm-Message-State: AA+aEWZi0GJWLihHQuA7BMmLmZLY4+VQgcpCyO0JB9jVQ2PwKzhXnh97 Xx3sqwEHIaUuE8LOFgcG18PeaQ== X-Google-Smtp-Source: AFSGD/XgXDxbb60knd/8dtpR4JTVtHMkIIzwSxbnpI3i5TQLKIDqDHyjs4cCB5fIbFw5gwyP1pjkbw== X-Received: by 2002:adf:9022:: with SMTP id h31-v6mr1395953wrh.297.1542710330314; Tue, 20 Nov 2018 02:38:50 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f192sm12107793wmd.12.2018.11.20.02.38.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 02:38:49 -0800 (PST) Date: Tue, 20 Nov 2018 10:38:48 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20181120103848.5lwyc4khz3juvguw@bivouac.eciton.net> References: <20181116065702.30559-1-ming.huang@linaro.org> <20181116065702.30559-7-ming.huang@linaro.org> <20181119183049.drqgb5uefxkwyqkx@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 06/15] Hisilicon/D06: Move some functions to OemMiscLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:38:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 20, 2018 at 02:38:32PM +0800, Ming Huang wrote: > > My feedback was: > > --- > > This would be more clear as "platform specific" than "cpld relative". > > > > I did not realise this wasn't a Hisilicon component when reviewing the > > original set. > > > > I approve of this change, but can you tell me why it is included in > > this set? If the goal is to make the M41T83 support platform > > independent, should the library also move to Silicon/ST/? > > --- > > > > So could you please update the commit message, and add a subsequent > > patch moving Library/M41T83RealTimeClockLib to > > Silicon/STMicroelectronics (and updating D06.dsc to match)? > > I do not care if it is not perfectly abstracted yet - we can deal with > > that when we have other users of the component in the tree. > > Sorry for missing update the commit message this patch. > I will update it in v3. I try to move the library to Silicon/STMicroelectronics, > but M41T83RealTimeClockLib depend on I2CLib in Hisilicon, so can't move the > library to STMicroelectronics. Main gist of this patch > is making this library as a common module in Hisilicon. And a PCI component depends on PciLib - that does not mean it should live in edk2 MdePkg. And it does not mean that this library should be considered Hisilicon-specific. If we get other platforms with this component, they will not be permitted to add duplicated code - we will then need to make sure the library is suitable for all users. There is no situation other than the maintainers (me) dropping the ball that lets you have a private driver for a generic component. Regardless, I will leave this patch out for now, to avoid delaying the release. / Leif