From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vijayenthiran.subramaniam@arm.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=217.140.101.70; helo=foss.arm.com;
 envelope-from=vijayenthiran.subramaniam@arm.com;
 receiver=edk2-devel@lists.01.org 
Received: from foss.arm.com (foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id 6228821190710
 for <edk2-devel@lists.01.org>; Tue, 20 Nov 2018 02:40:02 -0800 (PST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB8C580D;
 Tue, 20 Nov 2018 02:40:01 -0800 (PST)
Received: from usa.arm.com (a074939-lin.blr.arm.com [10.162.0.38])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1EB3D3F575;
 Tue, 20 Nov 2018 02:39:59 -0800 (PST)
From: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
To: edk2-devel@lists.01.org,
	siyuan.fu@intel.com,
	jiaxin.wu@intel.com
Cc: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Date: Tue, 20 Nov 2018 16:09:54 +0530
Message-Id: <20181120103954.18938-1-vijayenthiran.subramaniam@arm.com>
X-Mailer: git-send-email 2.17.1
Subject: [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 10:40:02 -0000

Add debug messages for failed attempts to write to a variable.

Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
 NetworkPkg/IScsiDxe/IScsiMisc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index dd0d32dcda16..46760d79a8f3 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -845,6 +845,8 @@ IScsiCreateAttempts (
                     );
     FreePool (AttemptConfigOrder);
     if (EFI_ERROR (Status)) {
+      DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n",
+        __FUNCTION__, Status));
       return Status;
     }
 
@@ -887,6 +889,8 @@ IScsiCreateAttempts (
                     );
     FreePool (AttemptConfigData);
     if (EFI_ERROR (Status)) {
+      DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n",
+        __FUNCTION__, Status));
       return Status;
     }
   }
-- 
2.17.1