Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote:
> Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> package. This driver requires the platform to support a maximum variable
> size of atleast 4KB.
> 
> So increase the maximum supported variable size to 8KB on the SGI
> platforms. Without this, the iSCSI driver fails to load.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>

Looks good to me, but I'd like an R-b from Thomas/Nariman.

On a separate note, MdeModulePkg maintainers - is this reason enough
to change the default of this Pcd?

/
    Leif

> ---
>  Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> index 3f0ca9872e79..1c152fad2246 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
> @@ -102,6 +102,7 @@
>  
>  [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdVFPEnabled|1
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
>  
>    # DRAM Block2 Base and Size
>    gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000
> -- 
> 2.17.1
>