From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 906982119358F for ; Tue, 20 Nov 2018 05:15:50 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id b13so1934466wrx.6 for ; Tue, 20 Nov 2018 05:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x2zvGpnzBHqJtNeJNzKqfmt1t5QRz1YtSr5VkaBwOKk=; b=j3/nvndQVhHgDRF3S0J34FCba2n5V1pdr3kTGFX/5dyGCfQTym5Ai+a2D5O9+S7RhI sxTKSiPvRcwaYuR2Kd/zZ14pxyxzJR5iUEBATI8eqV1tPoB1SYS4fdqwt3eU1YjCNzpy P6ktKDwawYo5F2xq1FqDRIxcujk3s1tc4/db4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x2zvGpnzBHqJtNeJNzKqfmt1t5QRz1YtSr5VkaBwOKk=; b=TrLnF5kNd8305Y0EoOmF/PdxWUOQAD2evBAGRQN4v1+a7amRkao4OzI4tUUo/7CMzY 7Kz5YLtucksSXrPLqhypT9L+1RtNNyTt5/cP7gdPkXK465xN/Jefh8omgvizCHfiUtYo DFmlTvYGifVy4tNv1lunEM9bSSITNV3u1rJmMPCmg6ob229BsplqIAhf6iMFvLF3sK2W fnyKurp0QGW3+DlFL/X9h9KwFwabxEait8TvBd273+TqI7VLi2ODA6DG5+oAKNILPBTs bpsdEobzfytlalGpAVQGW+cdbrL7XBw7xKtq3n4t7zku0lcEosCdU9Jd6gBdU4CnYYiE 8EKQ== X-Gm-Message-State: AA+aEWZtoO/rqS1tCmxI3+qkEENbJgij55R9L6Ry+t7cMXPidPdgdCMO cMGEryUpQVoYVdOjXpygh9zWXA== X-Google-Smtp-Source: AFSGD/UXo1MAfs9yut3Q35tQq1GcI791RceinBKYM4NWplBNJj0dw0Q6Bq+ZP6W33+6lETB/Rm8V/g== X-Received: by 2002:a5d:5284:: with SMTP id c4-v6mr1849022wrv.210.1542719748803; Tue, 20 Nov 2018 05:15:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 6-v6sm22687327wmd.45.2018.11.20.05.15.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 05:15:47 -0800 (PST) Date: Tue, 20 Nov 2018 13:15:46 +0000 From: Leif Lindholm To: Vijayenthiran Subramaniam Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, Thomas Panakamattam Abraham , Nariman Poushin , Star Zeng , Jian J Wang Message-ID: <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net> References: <20181120103102.17775-1-vijayenthiran.subramaniam@arm.com> MIME-Version: 1.0 In-Reply-To: <20181120103102.17775-1-vijayenthiran.subramaniam@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 13:15:51 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > package. This driver requires the platform to support a maximum variable > size of atleast 4KB. > > So increase the maximum supported variable size to 8KB on the SGI > platforms. Without this, the iSCSI driver fails to load. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam Looks good to me, but I'd like an R-b from Thomas/Nariman. On a separate note, MdeModulePkg maintainers - is this reason enough to change the default of this Pcd? / Leif > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc > index 3f0ca9872e79..1c152fad2246 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc > @@ -102,6 +102,7 @@ > > [PcdsFixedAtBuild.common] > gArmTokenSpaceGuid.PcdVFPEnabled|1 > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > > # DRAM Block2 Base and Size > gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000 > -- > 2.17.1 >