From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D28221191729 for ; Tue, 20 Nov 2018 06:52:53 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id b13so2285093wrx.6 for ; Tue, 20 Nov 2018 06:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QvHL1SsEvYFszJItaHudrymHWmtFst4cmHQxL2Nwg2A=; b=h4PikFf/xQa4oQlcbZKeHUMDa9z/Q0Wfe8VHn7vWYkqZ5ZG+VGKb8q4tSgGkiyVeiH aiiSHu29uEJUX7pxJmfj327uDRZJAi+TsrqI3DBtOQ5Lrmqq4HSpsNlTBjn2Yd0908sb NHRwk/2wRgAwbUYW5BE/fDdz0EMcPhMAmdSVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QvHL1SsEvYFszJItaHudrymHWmtFst4cmHQxL2Nwg2A=; b=hJC1wvK5Pu8kVumTJt5jCt1+tStzLeY9/EjVJAIPwAOxN7Zt5FhVQJ491zr79kEABX 2w7kV4BtaWHvYeW9nLBjuzasYk0qBe+t/1UIweKY9+lxaWigL4GA4bQh4fipCUF7C8d9 mXSBgEYzk5yZXJWnuD+RlavRXZxH248Us4XQVK5iHeKJAS9x7RnPsY2f9ibb2Fw8gs3/ 7Y1s4X6EslcrCWjnosRdMHzfJE693mqXYy6UoN+mH2PtfWKFtY4rAWKr+khyjoIffWjj JXPHjYrOUSfgyC3REImzlMLAN/x5PfZ2xV85tcLgUEjK2N/ZOkSa99emEx1QgIJ2blSa Yw+Q== X-Gm-Message-State: AA+aEWYKfEQIL5zksxPJ2cSfl7FWEK/pnkJIWszTHtb4ztb0vhUNTRz5 Tu31GCJzKmPxMnnoMFZw4axeTQ== X-Google-Smtp-Source: AFSGD/UAVdxskZcTW88997m1rgdKO25e2xu2ctEMizukOS3XkFcIGzMGZGketveQRNq/AfcINqSerA== X-Received: by 2002:adf:f308:: with SMTP id i8mr2149878wro.219.1542725572081; Tue, 20 Nov 2018 06:52:52 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e7-v6sm33523326wra.10.2018.11.20.06.52.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 06:52:50 -0800 (PST) Date: Tue, 20 Nov 2018 14:52:49 +0000 From: Leif Lindholm To: Thomas Abraham Cc: vijayenthiran.subramaniam@arm.com, edk2-devel@lists.01.org, star.zeng@intel.com, Nariman Poushin Message-ID: <20181120145249.xh2kzefgrqlspcwb@bivouac.eciton.net> References: <20181120103102.17775-1-vijayenthiran.subramaniam@arm.com> <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 14:52:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 20, 2018 at 07:32:35PM +0530, Thomas Abraham wrote: > On Tue, Nov 20, 2018 at 6:45 PM Leif Lindholm wrote: > > > > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: > > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > > > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > > > package. This driver requires the platform to support a maximum variable > > > size of atleast 4KB. > > > > > > So increase the maximum supported variable size to 8KB on the SGI > > > platforms. Without this, the iSCSI driver fails to load. > > > > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Vijayenthiran Subramaniam > > > > Looks good to me, but I'd like an R-b from Thomas/Nariman. > > Reviewed-by: Thomas Abraham Thanks! Reviewed-by: Leif Lindholm Pushed as d9e68a756c. > > > > On a separate note, MdeModulePkg maintainers - is this reason enough > > to change the default of this Pcd? > > > > / > > Leif > > > > > --- > > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc > > > index 3f0ca9872e79..1c152fad2246 100644 > > > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc > > > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc > > > @@ -102,6 +102,7 @@ > > > > > > [PcdsFixedAtBuild.common] > > > gArmTokenSpaceGuid.PcdVFPEnabled|1 > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > > > > > > # DRAM Block2 Base and Size > > > gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000 > > > -- > > > 2.17.1 > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel