public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
To: edk2-devel@lists.01.org, siyuan.fu@intel.com, jiaxin.wu@intel.com
Cc: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Subject: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts
Date: Wed, 21 Nov 2018 21:05:59 +0530	[thread overview]
Message-ID: <20181121153559.12134-1-vijayenthiran.subramaniam@arm.com> (raw)

Add debug messages for failed attempts to write to a variable.

Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
Made the log messages bit more useful. 

Thanks,
Vijayenthiran

 NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index dd0d32dcda16..7bed95a8fba3 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -845,6 +845,10 @@ IScsiCreateAttempts (
                     );
     FreePool (AttemptConfigOrder);
     if (EFI_ERROR (Status)) {
+      DEBUG ((DEBUG_ERROR,
+        "%a: Failed to set 'InitialAttemptOrder' with Guid (%g): "
+        "%r\n",
+        __FUNCTION__, &gIScsiConfigGuid, Status));
       return Status;
     }
 
@@ -887,6 +891,10 @@ IScsiCreateAttempts (
                     );
     FreePool (AttemptConfigData);
     if (EFI_ERROR (Status)) {
+        DEBUG ((DEBUG_ERROR,
+          "%a: Failed to set variable (mPrivate->PortString) with Guid (%g): "
+          "%r\n",
+          __FUNCTION__, &gEfiIScsiInitiatorNameProtocolGuid, Status));
       return Status;
     }
   }
-- 
2.17.1



             reply	other threads:[~2018-11-21 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 15:35 Vijayenthiran Subramaniam [this message]
2018-11-23  6:23 ` [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts Fu, Siyuan
2018-11-23  6:51 ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181121153559.12134-1-vijayenthiran.subramaniam@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox