From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=vijayenthiran.subramaniam@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 3F25821B02822 for ; Wed, 21 Nov 2018 07:36:11 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0235331A; Wed, 21 Nov 2018 07:36:11 -0800 (PST) Received: from usa.arm.com (a074939-lin.blr.arm.com [10.162.0.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1C4CB3F5CF; Wed, 21 Nov 2018 07:36:09 -0800 (PST) From: Vijayenthiran Subramaniam To: edk2-devel@lists.01.org, siyuan.fu@intel.com, jiaxin.wu@intel.com Cc: Vijayenthiran Subramaniam Date: Wed, 21 Nov 2018 21:05:59 +0530 Message-Id: <20181121153559.12134-1-vijayenthiran.subramaniam@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [PATCH v2] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 15:36:12 -0000 Add debug messages for failed attempts to write to a variable. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Made the log messages bit more useful. Thanks, Vijayenthiran NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c index dd0d32dcda16..7bed95a8fba3 100644 --- a/NetworkPkg/IScsiDxe/IScsiMisc.c +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c @@ -845,6 +845,10 @@ IScsiCreateAttempts ( ); FreePool (AttemptConfigOrder); if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to set 'InitialAttemptOrder' with Guid (%g): " + "%r\n", + __FUNCTION__, &gIScsiConfigGuid, Status)); return Status; } @@ -887,6 +891,10 @@ IScsiCreateAttempts ( ); FreePool (AttemptConfigData); if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to set variable (mPrivate->PortString) with Guid (%g): " + "%r\n", + __FUNCTION__, &gEfiIScsiInitiatorNameProtocolGuid, Status)); return Status; } } -- 2.17.1