[PATCH] Platform/ARM/Juno: increase max variable size to 8KB

[PATCH] Platform/ARM/Juno: increase max variable size to 8KB

[Vijayenthiran Subramaniam]

Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
package. This driver requires the platform to support a maximum variable
size of atleast 4KB.

So increase the maximum supported variable size to 8KB on the Juno
platform. Without this, the iSCSI driver fails to load.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
 Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
index ac3d63b..ac85dc0 100644
--- a/Platform/ARM/JunoPkg/ArmJuno.dsc
+++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
@@ -103,6 +103,8 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x0BFE0000
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000
 
+  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
+
   # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
   gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
 
-- 
2.7.4

Re: [PATCH] Platform/ARM/Juno: increase max variable size to 8KB

[Thomas Abraham]

On Wed, Nov 21, 2018 at 9:26 PM Vijayenthiran Subramaniam
<vijayenthiran.subramaniam@arm.com> wrote:
>
> Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> package. This driver requires the platform to support a maximum variable
> size of atleast 4KB.
>
> So increase the maximum supported variable size to 8KB on the Juno
> platform. Without this, the iSCSI driver fails to load.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
>  Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++
>  1 file changed, 2 insertions(+)

Tested-by: Thomas Abraham <thomas.abraham@gmail.com>

>
> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> index ac3d63b..ac85dc0 100644
> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> @@ -103,6 +103,8 @@
>    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x0BFE0000
>    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000
>
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> +
>    # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
>    gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
>
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] Platform/ARM/Juno: increase max variable size to 8KB

[Ard Biesheuvel]

On Wed, 21 Nov 2018 at 17:37, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> On Wed, Nov 21, 2018 at 9:26 PM Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com> wrote:
> >
> > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> > package. This driver requires the platform to support a maximum variable
> > size of atleast 4KB.
> >
> > So increase the maximum supported variable size to 8KB on the Juno
> > platform. Without this, the iSCSI driver fails to load.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Thomas Abraham <thomas.abraham@arm.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> >  Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Tested-by: Thomas Abraham <thomas.abraham@gmail.com>
>

Pushed as d9e68a756cfb..397bbafdbff3

Thanks all


> >
> > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> > index ac3d63b..ac85dc0 100644
> > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> > @@ -103,6 +103,8 @@
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x0BFE0000
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000
> >
> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > +
> >    # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
> >    gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel