public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, thomas.abraham@arm.com,
	nariman.poushin@linaro.org, lersek@redhat.com, philmd@redhat.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib
Date: Fri, 23 Nov 2018 09:44:03 +0100	[thread overview]
Message-ID: <20181123084406.27192-1-ard.biesheuvel@linaro.org> (raw)

The deprecated BdsLib library class in ArmPkg is still depended upon, but
only a single implementation exists, which now resides in edk2-platforms.

This implementation has some issues in how it deals with Device Paths,
so let's fix those, but first move over the library interface declaration
and get rid of the parts that are no longer used. This will permit dropping
it from ArmPkg in EDK2.

Changes since v1:
- add Laszlo's ack to #1
- update #2 to remove everything we no longer need from BdsLib
- drop #3 which was bogus
- update #4 to ensure that we only duplicate the device path when we
  are about to return EFI_SUCCESS

Ard Biesheuvel (3):
  Platform/ARM: import ARM platform specific BdsLib header
  Platform/ARM/BdsLib: drop unused functions
  Platform/ARM/BdsLib: maintain alignment for DevicePaths

 Platform/ARM/ARM.dec                          |   3 +
 .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   2 +-
 Platform/ARM/Include/Library/BdsLib.h         |  26 ++
 Platform/ARM/Library/BdsLib/BdsAppLoader.c    | 253 ----------------
 Platform/ARM/Library/BdsLib/BdsFilePath.c     |  95 +-----
 Platform/ARM/Library/BdsLib/BdsHelper.c       | 122 --------
 Platform/ARM/Library/BdsLib/BdsInternal.h     |  16 +-
 Platform/ARM/Library/BdsLib/BdsLib.inf        |   4 +-
 Platform/ARM/Library/BdsLib/BdsLoadOption.c   | 272 ------------------
 9 files changed, 52 insertions(+), 741 deletions(-)
 create mode 100644 Platform/ARM/Include/Library/BdsLib.h
 delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c
 delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c

-- 
2.17.1



             reply	other threads:[~2018-11-23  8:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23  8:44 Ard Biesheuvel [this message]
2018-11-23  8:44 ` [PATCH v2 edk2-platforms 1/3] Platform/ARM: import ARM platform specific BdsLib header Ard Biesheuvel
2018-11-23  8:44 ` [PATCH v2 edk2-platforms 2/3] Platform/ARM/BdsLib: drop unused functions Ard Biesheuvel
2018-11-23 12:39   ` Laszlo Ersek
2018-11-23  8:44 ` [PATCH v2 edk2-platforms 3/3] Platform/ARM/BdsLib: maintain alignment for DevicePaths Ard Biesheuvel
2018-11-23 12:46   ` Laszlo Ersek
2018-11-23 14:15 ` [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib Thomas Abraham
2018-11-23 15:17   ` Ard Biesheuvel
2018-11-26 15:06 ` Leif Lindholm
2018-11-26 16:53   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123084406.27192-1-ard.biesheuvel@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox