From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E6CB21B02822 for ; Fri, 23 Nov 2018 00:44:11 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 125so11162599wmh.0 for ; Fri, 23 Nov 2018 00:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=bGkSn8AvJQOtiFoxVsAUhJDlnZg12rL8Zwk1iVY8xYo=; b=WlJebPjwSSoPnXh3MElG5YcbOHvuHYhki4mCFpwPjfJ/xikJngOuHA+YP0x4vk0KDZ 5Ej5UKa/qrEdnJJvAnE1obeUlKvVngEdF3yptYJs3eJciYA7c8c2IPUnI9vDSITK8hjP pshiNpqIRcCP+xWP9Fo8Cxclurip+qh5rp84s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bGkSn8AvJQOtiFoxVsAUhJDlnZg12rL8Zwk1iVY8xYo=; b=RhAX9IzA8oh4AKxZNj7sElO663Og9VwFYAW6hXRGLV1/0C3WMSo3T3kWby65bKOjid uG28z+Iw5FppLyWQNOqjzg5OL+BCiM4DM1oXwmo8LTMLFw5YqOBY3bb65MO0FAhPBrKr cUUB4RRP+h5OMUqEijf5mcAPXlOMk7xpao0kfKjSGiWLBQb611bQ7zsNKO4I9AHit5my dhi/XSLoVh+5mKU+i1PQo44QoNU5/g2PQOMpkG5bSDaW4wQfo+qnuIKs+5WQPiAV9CL7 k9Re5LUg88/dnWUR9b72Er59hzjP0M3v4sEtWq0ggRQ+TAdcNc2U2xRPX0FXKjS6VAbA 0ufA== X-Gm-Message-State: AA+aEWahUQkbEmOHM8U4kblSFH8BeJhKeTDOcTVo/Vmt6Oa3YjPOzW5o XREcwq0hyXE82BfLmDototunv/JR0oLXIQ== X-Google-Smtp-Source: AFSGD/UXJo50l2BT6TNA1Z1IxFVokDUkrA98QimwjsEb1BIkyI8esLZCKb4qneKTgqEkUrD+e8g0lA== X-Received: by 2002:a1c:3b82:: with SMTP id i124-v6mr11776562wma.34.1542962648481; Fri, 23 Nov 2018 00:44:08 -0800 (PST) Received: from mba13.wifi.ns.nl (33.153.69.91.rev.sfr.net. [91.69.153.33]) by smtp.gmail.com with ESMTPSA id c8sm807377wrx.42.2018.11.23.00.44.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 00:44:07 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, thomas.abraham@arm.com, nariman.poushin@linaro.org, lersek@redhat.com, philmd@redhat.com, Ard Biesheuvel Date: Fri, 23 Nov 2018 09:44:03 +0100 Message-Id: <20181123084406.27192-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 Subject: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 08:44:11 -0000 The deprecated BdsLib library class in ArmPkg is still depended upon, but only a single implementation exists, which now resides in edk2-platforms. This implementation has some issues in how it deals with Device Paths, so let's fix those, but first move over the library interface declaration and get rid of the parts that are no longer used. This will permit dropping it from ArmPkg in EDK2. Changes since v1: - add Laszlo's ack to #1 - update #2 to remove everything we no longer need from BdsLib - drop #3 which was bogus - update #4 to ensure that we only duplicate the device path when we are about to return EFI_SUCCESS Ard Biesheuvel (3): Platform/ARM: import ARM platform specific BdsLib header Platform/ARM/BdsLib: drop unused functions Platform/ARM/BdsLib: maintain alignment for DevicePaths Platform/ARM/ARM.dec | 3 + .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- Platform/ARM/Include/Library/BdsLib.h | 26 ++ Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ---------------- Platform/ARM/Library/BdsLib/BdsFilePath.c | 95 +----- Platform/ARM/Library/BdsLib/BdsHelper.c | 122 -------- Platform/ARM/Library/BdsLib/BdsInternal.h | 16 +- Platform/ARM/Library/BdsLib/BdsLib.inf | 4 +- Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ------------------ 9 files changed, 52 insertions(+), 741 deletions(-) create mode 100644 Platform/ARM/Include/Library/BdsLib.h delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c -- 2.17.1