* [PATCH] Platform/Comcast: drop bogus BdsLib.h include
@ 2018-11-23 18:53 Ard Biesheuvel
2018-11-26 15:11 ` Leif Lindholm
0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2018-11-23 18:53 UTC (permalink / raw)
To: edk2-devel
RdkBootManagerLib/RdkBootManagerLib.h includes BdsLib.h from ArmPkg
but does not actually depend on it. So drop the #include.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
index 9d6e7dd1b677..6a18e95c1ced 100644
--- a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
+++ b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
@@ -13,7 +13,6 @@
#ifndef __RDK_BOOT_MANAGER_LIB_H__
#define __RDK_BOOT_MANAGER_LIB_H__
-#include <Library/BdsLib.h>
#include <Library/UefiLib.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Platform/Comcast: drop bogus BdsLib.h include
2018-11-23 18:53 [PATCH] Platform/Comcast: drop bogus BdsLib.h include Ard Biesheuvel
@ 2018-11-26 15:11 ` Leif Lindholm
0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2018-11-26 15:11 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Fri, Nov 23, 2018 at 07:53:21PM +0100, Ard Biesheuvel wrote:
> RdkBootManagerLib/RdkBootManagerLib.h includes BdsLib.h from ArmPkg
> but does not actually depend on it. So drop the #include.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
> index 9d6e7dd1b677..6a18e95c1ced 100644
> --- a/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
> +++ b/Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.h
> @@ -13,7 +13,6 @@
> #ifndef __RDK_BOOT_MANAGER_LIB_H__
> #define __RDK_BOOT_MANAGER_LIB_H__
>
> -#include <Library/BdsLib.h>
> #include <Library/UefiLib.h>
> #include <Library/BaseLib.h>
> #include <Library/DebugLib.h>
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-26 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-23 18:53 [PATCH] Platform/Comcast: drop bogus BdsLib.h include Ard Biesheuvel
2018-11-26 15:11 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox