From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sughosh.ganu@arm.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=217.140.101.70; helo=foss.arm.com;
 envelope-from=sughosh.ganu@arm.com; receiver=edk2-devel@lists.01.org 
Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id D7BCD21B02822
 for <edk2-devel@lists.01.org>; Sat, 24 Nov 2018 21:58:53 -0800 (PST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C50235A4;
 Sat, 24 Nov 2018 21:58:53 -0800 (PST)
Received: from a074948-lin.blr.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.72.51.249])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03F133F5A0;
 Sat, 24 Nov 2018 21:58:50 -0800 (PST)
Received: by a074948-lin.blr.arm.com (sSMTP sendmail emulation);
 Sun, 25 Nov 2018 11:28:48 +0530
Date: Sun, 25 Nov 2018 11:28:48 +0530
From: Sughosh Ganu <sughosh.ganu@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, leif.lindholm@linaro.org,
 edk2-devel@lists.01.org
Message-ID: <20181125055848.GA5324@arm.com>
References: <1540452759-4875-1-git-send-email-sughosh.ganu@arm.com>
 <1540452759-4875-7-git-send-email-sughosh.ganu@arm.com>
 <CAKv+Gu-RexTJi6gPjq2frMSxMDKAW9v7Pi15aybYSy0V0W00pA@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu-RexTJi6gPjq2frMSxMDKAW9v7Pi15aybYSy0V0W00pA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [PATCH v3 6/6] ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2018 05:58:54 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

hi Ard,

On Fri Nov 23, 2018 at 07:28:19PM +0100, Ard Biesheuvel wrote:
> On Thu, 25 Oct 2018 at 09:33, Sughosh Ganu <sughosh.ganu@arm.com> wrote:
> >
> > From: Achin Gupta <achin.gupta@arm.com>
> >
> > This patch adds the definitions, sources, packages and library classes
> > needed to compile and link MMU Library suitable for use in S-EL0.
> >
> > Currently, this is used only during the Standalone MM Core
> > initialization and hence defined as MM_CORE_STANDALONE Module.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@arm.com>
> > ---
> >  ArmPkg/Library/ArmMmuLib/{ArmMmuPeiLib.inf => ArmMmuStandaloneMmCoreLib.inf} | 23 +++++++++-----------
> 
> The code in the previous patch looks fine, but I'd prefer it if we
> expose this as a separate library class, not ArmMmuLib
> 
> So please just add a new file, say,
> ArmPkg/include/Library/StandaloneMmMmuLib.h, add only the functions
> you need, and add it to the LibraryClasses section of ArmPkg.dec as a
> new library class.
> 
> Then, you can modify the previous patch to include an updated .inf
> that describes it as being an implementation of StandaloneMmMmuLib.
> You can then also drop the unimplemented ArmConfigureMmu etc.

Thanks for reviewing the patches. I will incorporate the review
comments from both the patches, and post a V4 in the coming week.

-sughosh