Re: [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Nov 21, 2018 at 02:26:23AM +0100, Marcin Wojtas wrote:
> Hi Leif,
> 
> śr., 14 lis 2018 o 18:33 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> >
> > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote:
> > > > I think all of my comments on this patch can be summarised as "what is
> > > > an AP in this context"?
> > > >
> > > > The term either needs explicit documenting, or expansion in the macro
> > > > names such that documentation is not required.
> > >
> > > Isn't a glossary on top of this file:
> > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h#L13
> > > and C file:
> > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c#L13
> > > sufficient?
> >
> > I will confess I missed that. But that also clearly shows the problem.
> >
> > The glossary in is sufficient according to the coding style.
> > But it gets confusing, specifically for the abbreviation "AP", since
> > this has a specific (and different) meaning in PI.
> 
> Xenon is in, so we can focus on the GPIO ;) I will use AP806 in order
> to avoid confusion.

Thanks, that works for me.

> Please don't mind my ignorance - what is the default 'AP' meaning?

Application Processor. In contrast to the BootStrap Processor (BSP),
when using the EFI_MP_SERVICES_PROTOCOL to assign isolated tasks to
other logical processors.

> BoardDesc library patches will be affected when rebasing onto latest
> merged patches - should I resend v2 or wait for more remarks?

Hold back for a few more days please.

/
    Leif