From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 711E921194864 for ; Mon, 26 Nov 2018 06:49:47 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id p4so19217796wrt.7 for ; Mon, 26 Nov 2018 06:49:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DyM7weujHDD5cCbG9M+dj5CxPgkW1yzA1H4nYNBOoxk=; b=Nzctdkke+dxa82EA/Xgq/pLQMfzK1+uqjWHM0N16VtA0sy9szxQcMSBApfLPdr2jOZ lpuV3Db11y4GBFKIKq7/sJ/Zqe53S226RsIrzFGjHAPfnrZMDvsUP9HBqIkSETMOSWki MYgq0LOcwiWfVOzqZ916cLIWIvJ7l4AW/mE3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DyM7weujHDD5cCbG9M+dj5CxPgkW1yzA1H4nYNBOoxk=; b=i/GLl6FHSzld5V4CfmW+lcEEn1DiBjGXLdIS7VnIUc+6p3an4WRFzRzHEb/T9xlL9J fSh1yBjSFnNUusMaIrEBHsyqJ9uRlA4iqQ/3Rm56t7cUoT2e3875dkV4ikndsq2zEtk2 PQjBTveRlxrIxq0tP3LUJ8VuLcBWqLO7AWfXmwFhSrWR1LoptAu1U9c4W6d2U6DcY6s9 m/l3j0AlgMDoZdC+3z6GftdF+i8eIrIs8u9zZI1IVcfUbxQuquWnOf2rV+Dt5SDpfMpo 9RRXBMwZfExmsJaTJucqmRf1lou7XHiWltc1ShLYmae2qWiDvJ5JnuV3OxzDdhOCum/a 3WAg== X-Gm-Message-State: AA+aEWZ4hreH8aEmg09VzujGX2SCGavEpTUwZM7qMfRta68iFCKC4Isp wg2DL4RF/NoUEThgS1c3FCQV5Q== X-Google-Smtp-Source: AFSGD/VEfpYrgdX2N3m9VtMEOSEo+cKl5SaEANe0zEBzy/eSAvN00eHEN0RE3Diaz8Ie/o+++LWMdw== X-Received: by 2002:a5d:548d:: with SMTP id h13mr22806087wrv.80.1543243785722; Mon, 26 Nov 2018 06:49:45 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 126-v6sm409958wme.48.2018.11.26.06.49.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 06:49:44 -0800 (PST) Date: Mon, 26 Nov 2018 14:49:42 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Message-ID: <20181126144942.dca4i7b6lz6ofchg@bivouac.eciton.net> References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-2-git-send-email-mw@semihalf.com> <20181114011044.inajftqy7qmfq7n3@bivouac.eciton.net> <20181114173339.edjjmygvmrirtzvc@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 14:49:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Nov 21, 2018 at 02:26:23AM +0100, Marcin Wojtas wrote: > Hi Leif, > > śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a): > > > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > > I think all of my comments on this patch can be summarised as "what is > > > > an AP in this context"? > > > > > > > > The term either needs explicit documenting, or expansion in the macro > > > > names such that documentation is not required. > > > > > > Isn't a glossary on top of this file: > > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h#L13 > > > and C file: > > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c#L13 > > > sufficient? > > > > I will confess I missed that. But that also clearly shows the problem. > > > > The glossary in is sufficient according to the coding style. > > But it gets confusing, specifically for the abbreviation "AP", since > > this has a specific (and different) meaning in PI. > > Xenon is in, so we can focus on the GPIO ;) I will use AP806 in order > to avoid confusion. Thanks, that works for me. > Please don't mind my ignorance - what is the default 'AP' meaning? Application Processor. In contrast to the BootStrap Processor (BSP), when using the EFI_MP_SERVICES_PROTOCOL to assign isolated tasks to other logical processors. > BoardDesc library patches will be affected when rebasing onto latest > merged patches - should I resend v2 or wait for more remarks? Hold back for a few more days please. / Leif