Re: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib

[Leif Lindholm <leif.lindholm@linaro.org>]

On Fri, Nov 23, 2018 at 09:44:03AM +0100, Ard Biesheuvel wrote:
> The deprecated BdsLib library class in ArmPkg is still depended upon, but
> only a single implementation exists, which now resides in edk2-platforms.
> 
> This implementation has some issues in how it deals with Device Paths,
> so let's fix those, but first move over the library interface declaration
> and get rid of the parts that are no longer used. This will permit dropping
> it from ArmPkg in EDK2.

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Changes since v1:
> - add Laszlo's ack to #1
> - update #2 to remove everything we no longer need from BdsLib
> - drop #3 which was bogus
> - update #4 to ensure that we only duplicate the device path when we
>   are about to return EFI_SUCCESS
> 
> Ard Biesheuvel (3):
>   Platform/ARM: import ARM platform specific BdsLib header
>   Platform/ARM/BdsLib: drop unused functions
>   Platform/ARM/BdsLib: maintain alignment for DevicePaths
> 
>  Platform/ARM/ARM.dec                          |   3 +
>  .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf |   2 +-
>  Platform/ARM/Include/Library/BdsLib.h         |  26 ++
>  Platform/ARM/Library/BdsLib/BdsAppLoader.c    | 253 ----------------
>  Platform/ARM/Library/BdsLib/BdsFilePath.c     |  95 +-----
>  Platform/ARM/Library/BdsLib/BdsHelper.c       | 122 --------
>  Platform/ARM/Library/BdsLib/BdsInternal.h     |  16 +-
>  Platform/ARM/Library/BdsLib/BdsLib.inf        |   4 +-
>  Platform/ARM/Library/BdsLib/BdsLoadOption.c   | 272 ------------------
>  9 files changed, 52 insertions(+), 741 deletions(-)
>  create mode 100644 Platform/ARM/Include/Library/BdsLib.h
>  delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c
>  delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c
> 
> -- 
> 2.17.1
>