From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 83C3F21195916 for ; Mon, 26 Nov 2018 07:06:50 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id 96so19309866wrb.2 for ; Mon, 26 Nov 2018 07:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A8OIAf6+HO439vq+VVkCplYlnnJcjOir8Vrb6ox5KkU=; b=JBC2kuA6b7xKQw4FEUgwBdjBIWnICi3g0cRxitvBQiN7U3ppgApXic8+Vjz11yg3+Y 3El3P7WRUg5BhgOQ+AwjdTbi4nO5Xw3GwCM3Z8ZOGymtBzL5zjRbol7av30dU3TA3FwH qvWugxjyPmtlSY9CKISNrMjsRBVlsfrSUrCpY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A8OIAf6+HO439vq+VVkCplYlnnJcjOir8Vrb6ox5KkU=; b=KjXDSCBnb79pDqTlnhoeOeTimmROQxRNU74ncZIxk8ZiPuMoXkiKQ14+KhNcUMZiEr 07jMC05aap1BYMHA9CW2SpwE3FmJp4odp+wRySU6GlP63wBiIVmGVQBFRGkZKf5113SS GBE8p9ronAjn9XqsiXjq1cyFLlNifQL3MybfqVsIxyOOmH9oORq2D4nNSF4mUpL8WoP+ KwCrwx4jQjzIX3QsX9kV1uCHn4GlDbvLHzWR4lwkKwvl4+ia7dDj9SaLXWt+yStUPsG/ N8guYl/0km0EQOLnYeoYrgsqGDEhTo8/qOaGwS2FAwa1AHSizuvC1P6yt6cCGpO+nSAr 0Mdw== X-Gm-Message-State: AA+aEWZ2Al8Q6HwN4d/0S5mCzuZSYuSDbC5HnXaK+8Zu0WZd+CGoRWli WePu46M3zagp3lWnNfTab/hrsYQw+DY= X-Google-Smtp-Source: AFSGD/WMnho7XKDTxNOtKX3mWu/ga91WkxXmMbM9yi9E91J6CNozwg1AkZCxXObqxDQCKYyPzaf/ig== X-Received: by 2002:adf:dd06:: with SMTP id a6mr25447423wrm.2.1543244808595; Mon, 26 Nov 2018 07:06:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m66sm1394703wmd.15.2018.11.26.07.06.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 07:06:47 -0800 (PST) Date: Mon, 26 Nov 2018 15:06:45 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, thomas.abraham@arm.com, nariman.poushin@linaro.org, lersek@redhat.com, philmd@redhat.com Message-ID: <20181126150645.lqtpo62uy257i25y@bivouac.eciton.net> References: <20181123084406.27192-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181123084406.27192-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 15:06:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 23, 2018 at 09:44:03AM +0100, Ard Biesheuvel wrote: > The deprecated BdsLib library class in ArmPkg is still depended upon, but > only a single implementation exists, which now resides in edk2-platforms. > > This implementation has some issues in how it deals with Device Paths, > so let's fix those, but first move over the library interface declaration > and get rid of the parts that are no longer used. This will permit dropping > it from ArmPkg in EDK2. For the series: Reviewed-by: Leif Lindholm > Changes since v1: > - add Laszlo's ack to #1 > - update #2 to remove everything we no longer need from BdsLib > - drop #3 which was bogus > - update #4 to ensure that we only duplicate the device path when we > are about to return EFI_SUCCESS > > Ard Biesheuvel (3): > Platform/ARM: import ARM platform specific BdsLib header > Platform/ARM/BdsLib: drop unused functions > Platform/ARM/BdsLib: maintain alignment for DevicePaths > > Platform/ARM/ARM.dec | 3 + > .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- > Platform/ARM/Include/Library/BdsLib.h | 26 ++ > Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ---------------- > Platform/ARM/Library/BdsLib/BdsFilePath.c | 95 +----- > Platform/ARM/Library/BdsLib/BdsHelper.c | 122 -------- > Platform/ARM/Library/BdsLib/BdsInternal.h | 16 +- > Platform/ARM/Library/BdsLib/BdsLib.inf | 4 +- > Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 ------------------ > 9 files changed, 52 insertions(+), 741 deletions(-) > create mode 100644 Platform/ARM/Include/Library/BdsLib.h > delete mode 100644 Platform/ARM/Library/BdsLib/BdsAppLoader.c > delete mode 100644 Platform/ARM/Library/BdsLib/BdsLoadOption.c > > -- > 2.17.1 >