From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 33E6B2119309E for ; Mon, 26 Nov 2018 10:41:04 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id v13so16596170wrw.5 for ; Mon, 26 Nov 2018 10:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+OiJOfqGJEpqxbUJqG6tGNwVZ3zBH51cFFhXXEzF1gE=; b=B4rE3KHSYRsnMEPgXO5e0lZ47R/LHFVXJMqjzKfxG6QzNz1uZrYlMABowGujPqe0Ja wy+4F9+TZvjnb3oEBG0Aj+cynbokXSurqzaUk+NK+Otaw7f91UHKcZCrLS108+OtfUNt qfUf3HgpbcixCLfO2uTJJ9R4NgHcq0WddmEwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+OiJOfqGJEpqxbUJqG6tGNwVZ3zBH51cFFhXXEzF1gE=; b=rhYHArqx8PMvTzvQShLKoFUqDsZgP5FhN93nNG2aY3MBnRbMak9g2Pr4bweH2welee eo0Odb/X0HcD0WuELuLdfXPpCg7tc+qnkdPqAjO7wnBFi1TNGIkykpFVGRKuHRCLRNU5 AKuoTstJmAgOjyLh/ATnYZvzv5U4dW7JQ1OtcopVzanEepvaRF82nnJ/Wmj/evTBxdg0 tlHsnPFT3WyLScQT5lmEITWKHtr+2pF7xkk8UmWsEpA9JuRZhNTschYmnTJ/uNjfFRzd gy2mB7R/HVO214We63LIiviWnt0dPyLVLD4/zZ/Xyho5tAKdVxTbzJf2Z88Mb9xayYK5 DHqg== X-Gm-Message-State: AA+aEWa9nC51v6TxvL4dkZBRGliqvj150ejVlmr9L7x147xQBUEtSX8h pbym9cr7HVf+Xb6GOGUe5LBXnA== X-Google-Smtp-Source: AFSGD/V7ySmC8zUg3H0NXGZKAdfm1PKtVwS7RtZzHxI7ebBb0xKFZTRIVblgTwbfEr4VYCNepN7ubg== X-Received: by 2002:adf:94e4:: with SMTP id 91mr10348339wrr.322.1543257662504; Mon, 26 Nov 2018 10:41:02 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x77sm2141358wme.19.2018.11.26.10.41.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 10:41:01 -0800 (PST) Date: Mon, 26 Nov 2018 18:41:00 +0000 From: Leif Lindholm To: Nariman Poushin Cc: edk2-devel@lists.01.org Message-ID: <20181126184100.ztkd27ct7pxkmjeh@bivouac.eciton.net> References: <1543237854-32562-1-git-send-email-nariman.poushin@linaro.org> MIME-Version: 1.0 In-Reply-To: <1543237854-32562-1-git-send-email-nariman.poushin@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/2] Readme.md: Update instructions to fetch source X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 18:41:04 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 26, 2018 at 01:10:53PM +0000, Nariman Poushin wrote: > Openssl is fetched as a git submodule, so make sure git clone --recursive > is specified in the instructions to fetch a full source tree. Can you add a Contributed-under: TianoCore Contribution Agreement 1.1 tag for all patches contributed to TianoCore? Preferably before the Signed-off-by. Other than that, this patch is good, thanks! > Signed-off-by: Nariman Poushin > > --- > Readme.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Readme.md b/Readme.md > index 6ad5953..bb53c6f 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building > platforms that need it) > ``` > - $ git clone https://github.com/tianocore/edk2.git > + $ git clone https://github.com/tianocore/edk2.git --recursive > ... > $ git clone https://github.com/tianocore/edk2-platforms.git > ... > -- > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel