From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, liming.gao@intel.com,
michael.d.kinney@intel.com, lersek@redhat.com, philmd@redhat.com
Subject: Re: [PATCH] MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits
Date: Tue, 27 Nov 2018 13:38:57 +0000 [thread overview]
Message-ID: <20181127133857.icycg74ta2p743ta@bivouac.eciton.net> (raw)
In-Reply-To: <20181127122748.24527-1-ard.biesheuvel@linaro.org>
On Tue, Nov 27, 2018 at 01:27:48PM +0100, Ard Biesheuvel wrote:
> AArch64 support the use of more than 48 bits for physical and/or
supports
> virtual addressing, but only if the page size is set to 64 KB,
> which is not supported by UEFI/EDK2. So redefine MAX_ADDRESS to
s/EDK2//
With those tweaks:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> cover only 48 address bits.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdePkg/Include/AArch64/ProcessorBind.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/AArch64/ProcessorBind.h b/MdePkg/Include/AArch64/ProcessorBind.h
> index 968c18f915ae..dad75df1c579 100644
> --- a/MdePkg/Include/AArch64/ProcessorBind.h
> +++ b/MdePkg/Include/AArch64/ProcessorBind.h
> @@ -138,9 +138,9 @@ typedef INT64 INTN;
> #define MAX_2_BITS 0xC000000000000000ULL
>
> ///
> -/// Maximum legal AARCH64 address
> +/// Maximum legal AARCH64 address (48 bits for 4 KB page size)
> ///
> -#define MAX_ADDRESS 0xFFFFFFFFFFFFFFFFULL
> +#define MAX_ADDRESS 0xFFFFFFFFFFFFULL
>
> ///
> /// Maximum legal AArch64 INTN and UINTN values.
> --
> 2.19.1
>
next prev parent reply other threads:[~2018-11-27 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 12:27 [PATCH] MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits Ard Biesheuvel
2018-11-27 13:38 ` Leif Lindholm [this message]
2018-11-27 14:51 ` Laszlo Ersek
2018-11-29 14:59 ` Gao, Liming
2018-11-29 18:02 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127133857.icycg74ta2p743ta@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox