From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4A21A21B02822 for ; Tue, 27 Nov 2018 05:39:01 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id n133so5474910wmd.4 for ; Tue, 27 Nov 2018 05:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NaIIIf6t4PZyfye32qIeJOcplAq2BHwoe+3mRagH4LM=; b=H5HIXwx5jG/KBnpFKgdbXo7kq08YV7ymQAcaebXcHLmDNW6b3xk9gTB7TzQf5pR1rY 0lRCnrjLagx9V8RDhLanBBybb+gyBrF2MoKoarGslShgqRU/mb7nVbyQzFFigU0ded8J SZJPpPrro6XQkd7apvuFsUlrfI/SgVCMUfOJs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NaIIIf6t4PZyfye32qIeJOcplAq2BHwoe+3mRagH4LM=; b=Kv0EoQt4hzYF6NINzrgeWEtE5lBkip1nte0HMmwbVjNg0Aeq4uhVUJmOK7C78wwN2S VY39Ur3GjRSvT6lL0WBcLzlmtFlRQEKFy4GwzTc+EIJOFnIhGHOh/djvOoSVDRIYUL9P 6Azknzx24AosgyjPdslvU/cpxSZT46t1/1nVUHfrrcj0Nnh22UaS8C/ane4DldyuIvPE vyQj7DatXO14W2gJIvcrpJciudiP5dLJeQRRhpL25uJX5mTG0i7pQ53AF0z/XpLynY0Q 29a+famHwR99AVoFgoaiOXUyc6XZqi2IvinLJI/+iGxjS7uDtiK1basZwiTBCTTn+rYo Qqkw== X-Gm-Message-State: AA+aEWbJ96vvvo5++7yfp923+HN3cy4c367fSH1EE2HVod2ODtvElk37 Evrj1tij1rKBepdEkKKYRDUuvw== X-Google-Smtp-Source: AJdET5dRP2+pDKvjIdJcrlsfuwJI2wtBh33ScxGeBJ/rhIGP8Rv+xR0IB/rZm0yKBvgP0p/TV1a5xg== X-Received: by 2002:a1c:7e8e:: with SMTP id z136mr29604887wmc.140.1543325940246; Tue, 27 Nov 2018 05:39:00 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j8sm4999331wmd.0.2018.11.27.05.38.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 05:38:59 -0800 (PST) Date: Tue, 27 Nov 2018 13:38:57 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, liming.gao@intel.com, michael.d.kinney@intel.com, lersek@redhat.com, philmd@redhat.com Message-ID: <20181127133857.icycg74ta2p743ta@bivouac.eciton.net> References: <20181127122748.24527-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181127122748.24527-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 13:39:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 27, 2018 at 01:27:48PM +0100, Ard Biesheuvel wrote: > AArch64 support the use of more than 48 bits for physical and/or supports > virtual addressing, but only if the page size is set to 64 KB, > which is not supported by UEFI/EDK2. So redefine MAX_ADDRESS to s/EDK2// With those tweaks: Reviewed-by: Leif Lindholm > cover only 48 address bits. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > MdePkg/Include/AArch64/ProcessorBind.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Include/AArch64/ProcessorBind.h b/MdePkg/Include/AArch64/ProcessorBind.h > index 968c18f915ae..dad75df1c579 100644 > --- a/MdePkg/Include/AArch64/ProcessorBind.h > +++ b/MdePkg/Include/AArch64/ProcessorBind.h > @@ -138,9 +138,9 @@ typedef INT64 INTN; > #define MAX_2_BITS 0xC000000000000000ULL > > /// > -/// Maximum legal AARCH64 address > +/// Maximum legal AARCH64 address (48 bits for 4 KB page size) > /// > -#define MAX_ADDRESS 0xFFFFFFFFFFFFFFFFULL > +#define MAX_ADDRESS 0xFFFFFFFFFFFFULL > > /// > /// Maximum legal AArch64 INTN and UINTN values. > -- > 2.19.1 >