From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 959F321196801 for ; Thu, 29 Nov 2018 07:13:39 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id q26so2586770wmf.5 for ; Thu, 29 Nov 2018 07:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hc5dQSNX1cH9PaUYkSyOv1d9BOQVXKJbTciZJ+zyQLY=; b=Ww7xgPb6FQ1Wg2rmAL+8ME2PS/bWXjBmV3VmkFA2K+9K2lY4zfJHdq2x3VFtfXDSRV cbu0dxQmmKRJEABvy31JjJ1fagp8hTKICKFkoljQpDyhC+QnEIbeg0EL3kf+fGqzGQ45 1ZalPYJg1cz45slLl/CQxD21isB82HDguMJxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hc5dQSNX1cH9PaUYkSyOv1d9BOQVXKJbTciZJ+zyQLY=; b=L3N5CYr5Hk/aqrMHyFCelLYkbsJas0d02cgFUD8wPnfA3SoGccJnFCnBLZhL1nhidd x9RreQuKa3mfzG7tlZJpu90HSFMctKqa/HCED/3ReFjkSoGE6CyNOWEPceIh+Iq9ps1c tBz7dvkHVXGPPGyCh0er4cMNl2AKaEpAN2/j8a5t2VY18k4V1wYJVBhZZkkECVyneMWk 6w6LROahH08tvLIEyQqJgZLB88aYpj8frsMAsBuM+TOPDN9csc+YSX1g6mO1Xq7pq2vj aiixBmybvxp9ZjbU6Bi1S5wJ0AKVseAU9SoU44JZ/DpXMF94cAt84WbDN/fJsQhZbWWX QX5A== X-Gm-Message-State: AA+aEWbcdqU1LDaYzYV9FxV1KShIWHCMCYjEikUxe3JTix8rY7muKizi uovF/wMXSlAkrnGg0VNRkWot9u+gteA= X-Google-Smtp-Source: AFSGD/X+N9ROj+p3QY6rMexzc6r1anko6aGkh/nkoAo1F9/TdBirWQi6UqgF9xdkWM2ZVxrjRezNbA== X-Received: by 2002:a1c:998e:: with SMTP id b136mr2239175wme.66.1543504417972; Thu, 29 Nov 2018 07:13:37 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 126-v6sm1491762wme.48.2018.11.29.07.13.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 07:13:34 -0800 (PST) Date: Thu, 29 Nov 2018 15:13:31 +0000 From: Leif Lindholm To: Chandni Cherukuri Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org Message-ID: <20181129151331.ikj7ve2zq2avqayb@bivouac.eciton.net> References: <1542804297-31957-1-git-send-email-chandni.cherukuri@arm.com> MIME-Version: 1.0 In-Reply-To: <1542804297-31957-1-git-send-email-chandni.cherukuri@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 edk2-platforms 0/6] Platform/ARM/Sgi: Add support for Clark.Ares and Clark.Helios platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:13:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline So, I'm actually mostly happy with this set, but this cover letter is incorrect. On Wed, Nov 21, 2018 at 06:14:51PM +0530, Chandni Cherukuri wrote: > Changes since v1: > - No code changes, posting this series again with correct patch subject Plenty of code changes. Stopped the masking and shifting of platform/config IDs. > This patch series adds support for two new Arm's SGI platforms - > SGI-Clark.Ares and SGI-Clark.Helios. The first patch in this > series adds support to use a new binding added to the system-id > node for Platform Identification. The second patch refactors the > ACPI tables to prevent duplication of ACPI tables. The common > ACPI tables for SGI platforms are put in the AcpiTables folder. > Dsdt.asl and Madt.aslc remain in the platform specific folder. > The rest of the patches add support for the two new SGI platforms. I am not super happy that the Change from COM1 -> \\_SB.COM0 got folded into Patch number 2, but I'm not going to ask for a v4 over it. For the series: Reviewed-by: Leif Lindholm Pushed as 86c75fc51f..77ae8610df. > Chandni Cherukuri (6): > Platform/ARM/Sgi: Adapt to changes in system-id DT node. > Platform/ARM/Sgi: Refactor ACPI tables for SGI platforms > Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Ares platform > Platform/ARM/Sgi: Add initial support for SGI-Clark.Ares platform > Platform/ARM/Sgi: Add ACPI tables for SGI-Clark.Helios platform > Platform/ARM/Sgi: Add initial support for SGI-Clark.Helios platform > > Platform/ARM/SgiPkg/SgiPlatform.dec | 2 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf | 58 ----- > Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 58 +++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 58 +++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 58 +++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 2 +- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 6 + > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 33 +-- > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 50 ++-- > Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc | 88 +++++++ > Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc | 87 +++++++ > Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc | 152 +++++++++++ > Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 106 ++++++++ > Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc | 59 +++++ > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc | 90 ------- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 2 +- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Fadt.aslc | 87 ------- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Gtdt.aslc | 152 ----------- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Iort.aslc | 106 -------- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Mcfg.aslc | 59 ----- > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Spcr.aslc | 77 ------ > Platform/ARM/SgiPkg/AcpiTables/Sgi575/Ssdt.asl | 95 ------- > Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 116 +++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc | 171 +++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl | 262 +++++++++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc | 266 ++++++++++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc | 77 ++++++ > Platform/ARM/SgiPkg/AcpiTables/Ssdt.asl | 93 +++++++ > 31 files changed, 1722 insertions(+), 758 deletions(-) > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/AcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dbg2.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Fadt.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Gtdt.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Iort.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Mcfg.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Spcr.aslc > delete mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Ssdt.asl > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc > create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Ssdt.asl > > -- > 2.7.4