From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EB62821193078 for ; Thu, 29 Nov 2018 07:39:18 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id l9so2339137wrt.13 for ; Thu, 29 Nov 2018 07:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TN9JIa0MnN6nMyxPSEGht/tFlrk7SDjw5fhErSWXcG0=; b=jcdymtDwoLWvO91AxMdCzsp/zfk8uh9X3qgc39nV2U1678Z8rpedvKZBuw+oHGFtRF Z4tchw82PFFsN3lskUOgAmEtBQHjXnvZE2OIzl+PrjDS1F+t6eJ4B7in/k4ibF09K1cd vnnN/dmKKJf/SzsxY7fPef5YtHcJfRvOF3iEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TN9JIa0MnN6nMyxPSEGht/tFlrk7SDjw5fhErSWXcG0=; b=XpzudnGD8myCWKD3HVRKiF6WkaqX4c+OcCCxgiJneuotYqDCsjUuaQmcIWI/sJZii/ ftjE92/5CrGOOFQiwOVRS1kY5uh0v3FthkEEGdm4CyZ00BFxxIPoWKJPJxTlI8ivwo4e ZIwbWO+5Ig2UppfkZJsBR9EZtlseOAZIcHJQKBj/X4HVcwSK6aP7YtdOrz8vEoS0u7sc l+XkIlpkptfRejQS1MgzqLodVMNfQL8ThS4IqfeJeh/9ZsQ4okeMuk3Xw8QgQBtsK4F/ hmVLfHD9Ixju15LPbEkTLHuZsiK8l04ptwSuoiUtMN9wcWfPlYUWSSNPaqUyQQtMb6KE XoFA== X-Gm-Message-State: AA+aEWZ/7EifPl+mVuEAMRoFrhQanje2rp3y/uthC/ctfRi3Lq+n5mAn 8RWAWh0xULGs7xZDzOStY9fYIA== X-Google-Smtp-Source: AFSGD/XtM4Nc+KdNMS42vYQNsmOeOZU97cVjSGWh3fK9a+Us34Pm+OmrmIMxKtSsm0lVqniiUjS+Nw== X-Received: by 2002:adf:f649:: with SMTP id x9mr1816806wrp.247.1543505957042; Thu, 29 Nov 2018 07:39:17 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p4sm1375208wrs.74.2018.11.29.07.39.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 07:39:16 -0800 (PST) Date: Thu, 29 Nov 2018 15:39:14 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Laszlo Ersek , Eric Auger , Andrew Jones , Philippe Mathieu-Daude , Julien Grall Message-ID: <20181129153914.fsadbfhnwttabgb2@bivouac.eciton.net> References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181128143357.991-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 01/16] EmbeddedPkg/TemplateSec: remove unused module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:39:19 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 03:33:42PM +0100, Ard Biesheuvel wrote: > Remove this module: it is unused, and should not be used as an > example going forward. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/TemplateSec/TemplateSec.inf | 65 ----------------- > EmbeddedPkg/TemplateSec/TemplateSec.c | 76 -------------------- > 2 files changed, 141 deletions(-) > > diff --git a/EmbeddedPkg/TemplateSec/TemplateSec.inf b/EmbeddedPkg/TemplateSec/TemplateSec.inf > deleted file mode 100644 > index 3a63e59294d3..000000000000 > --- a/EmbeddedPkg/TemplateSec/TemplateSec.inf > +++ /dev/null > @@ -1,65 +0,0 @@ > -#/** @file > -# > -# Component description file for DxeIpl module > -# > -# The responsibility of this module is to load the DXE Core from a Firmware Volume. This implementation i used to load a 32-bit DXE Core. > -# > -# Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = TemplateSec > - FILE_GUID = 1D6F730F-5A55-4078-869B-E0A18324BDC8 > - MODULE_TYPE = SEC > - VERSION_STRING = 1.0 > - > - > -# > -# The following information is for reference only and not required by the build tools. > -# > -# VALID_ARCHITECTURES = IA32 X64 ARM > -# > - > -[Sources.common] > - TemplateSec.c > - > -[Sources.Ia32] > -# Ia32/ResetVector.asm | MSFT > -# Ia32/ResetVector.S | GCC > - > -[Sources.X64] > -# X64/ResetVector.asm | MSFT > -# X64/ResetVector.S | GCC > - > -[Sources.ARM] > -# Arm/ResetVector.asm | RVCT > -# Arm/ResetVector.S | GCC > - > -[Packages] > - MdePkg/MdePkg.dec > - MdeModulePkg/MdeModulePkg.dec > - EmbeddedPkg/EmbeddedPkg.dec > - > - > -[LibraryClasses] > - BaseLib > - DebugLib > - BaseMemoryLib > - UefiDecompressLib > - PeCoffLib > - CacheMaintenanceLib > - PrePiLib > - > -[Pcd] > - gEmbeddedTokenSpaceGuid.PcdEmbeddedFdBaseAddress > - gEmbeddedTokenSpaceGuid.PcdEmbeddedFdSize > - > diff --git a/EmbeddedPkg/TemplateSec/TemplateSec.c b/EmbeddedPkg/TemplateSec/TemplateSec.c > deleted file mode 100644 > index c63adbb6f90f..000000000000 > --- a/EmbeddedPkg/TemplateSec/TemplateSec.c > +++ /dev/null > @@ -1,76 +0,0 @@ > -/** @file > - > - Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> - > - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#include > - > -#include > -#include > -#include > - > -#include > - > -VOID > -_ModuleEntryPoint ( > - VOID > - ) > -{ > -} > - > -VOID > -CEntryPoint ( > - VOID *MemoryBase, > - UINTN MemorySize, > - VOID *StackBase, > - UINTN StackSize > - ) > -{ > - EFI_PHYSICAL_ADDRESS MemoryBegin; > - UINT64 MemoryLength; > - VOID *HobBase; > - > - // > - // Boot strap the C environment so the other library services will work properly. > - // > - MemoryBegin = (EFI_PHYSICAL_ADDRESS)(UINTN)MemoryBase; > - MemoryLength = (UINT64)MemorySize; > - HobBase = (VOID *)(UINTN)(FixedPcdGet32(PcdEmbeddedFdBaseAddress) + FixedPcdGet32(PcdEmbeddedFdSize)); > - CreateHobList (MemoryBase, MemorySize, HobBase, StackBase); > - > - MemoryBegin = (EFI_PHYSICAL_ADDRESS)(UINTN)StackBase; > - MemoryLength = (UINT64)StackSize; > - UpdateStackHob (MemoryBegin, MemoryLength); > - > - DEBUG ((DEBUG_ERROR, "CEntryPoint (%x,%x,%x,%x)\n", MemoryBase, MemorySize, StackBase, StackSize)); > - > - // > - // Add your C code stuff here.... > - // > - > - > - // > - // Load the DXE Core and transfer control to it > - // > - > - // Give the DXE Core access to our DEBUG and ASSERT infrastructure so this will work prior > - // to the DXE version being loaded. Thus we close the debugging gap between phases. > - AddDxeCoreReportStatusCodeCallback (); > - > - //BuildFvHobs (PcdBfvBase, PcdBfvSize, NULL); > - > - LoadDxeCoreFromFv (NULL, 0); > - > - // DXE Core should always load and never return > - ASSERT (FALSE); > -} > - > -- > 2.19.1 >