From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F328021B02822 for ; Thu, 29 Nov 2018 07:40:24 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id c14so2388821wrr.0 for ; Thu, 29 Nov 2018 07:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oQ3HaEfH5VRm3+eeVAZb39Z3so50EB+gwoDQFpyZ6SI=; b=FxpdKwOQ3TMRfOS6q3m8XmxHKLBtFLsODYwWoIxxnH1zbG/sFkaearRZ/j45wqbGof gdgW6uhu1CL5zHtXLP+Rk1fYI+IjaJfOwHvrCsz7j1R+rp/GSRMc0MQXOlwu2DlhwctT Jsad0A5ReE61xfk4af0mJHBa0pfWwnZyPhnyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oQ3HaEfH5VRm3+eeVAZb39Z3so50EB+gwoDQFpyZ6SI=; b=tLzTKcKa/vhM95wHTAJ5G/xU41z+PWmbpZeRJqz9OVRY9nwIm/Vc/Y1fGvYAdY9tJp lCTyq0IQeXGdxNQIaskXPSNCza6NWbAtHt7GWR9ceWsPHG1QwcJP5tU3FK7mBWGLwJ6F 6ZTfLJFAB7F16weu/xTl33bE5SeQ0pnGQvbG1Qf9jdFwkibXCfnlpLCGatuIcPIWd+fR wIVAnQ8atkd/pBUwC2ooCTwxoeIrZWpd3oNgg3c/3KPDYFQk37Fceza6l6l6scfsX1Fw q+/pvicu1z7AbhiZ4FiuDX8fKJYbkH8ISzKz8chSezCX7hiKOzot+0PJhcW8pWWB4hyx 9RWQ== X-Gm-Message-State: AA+aEWY2EM/7ayKWHaSNmzvl5fbTZgSkVJ09swT3WqF67QbM/VXDw5ez KZKEWVx9vQMJGTGRKqck2ph67A== X-Google-Smtp-Source: AFSGD/WCf88KpxEFPvqV/d1MyNtsdbThHsuA/iStwdCXhk+WrG1OQR81Two4vP8o15kzFhqkOSEZTQ== X-Received: by 2002:a05:6000:1287:: with SMTP id f7mr1958407wrx.302.1543506023416; Thu, 29 Nov 2018 07:40:23 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 142sm3318918wmw.27.2018.11.29.07.40.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 07:40:22 -0800 (PST) Date: Thu, 29 Nov 2018 15:40:21 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Laszlo Ersek , Eric Auger , Andrew Jones , Philippe Mathieu-Daude , Julien Grall Message-ID: <20181129154020.4wybvluhezch2ufm@bivouac.eciton.net> References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-3-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181128143357.991-3-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 02/16] EmbeddedPkg/PrePiHobLib: drop CreateHobList() from library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:40:25 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 03:33:43PM +0100, Ard Biesheuvel wrote: > Drop the declaration and the implementation of CreateHoblist(), > which is not used anywhere. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/Include/Library/PrePiLib.h | 18 --------- > EmbeddedPkg/Library/PrePiHobLib/Hob.c | 41 -------------------- > 2 files changed, 59 deletions(-) > > diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h b/EmbeddedPkg/Include/Library/PrePiLib.h > index cf70fca3b619..a857308ecec2 100644 > --- a/EmbeddedPkg/Include/Library/PrePiLib.h > +++ b/EmbeddedPkg/Include/Library/PrePiLib.h > @@ -274,24 +274,6 @@ HobConstructor ( > IN VOID *EfiFreeMemoryTop > ); > > -/** > - Retrieves the magic value from the PE/COFF header. > - > - @param Hdr The buffer in which to return the PE32, PE32+, or TE header. > - > - @return EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC - Image is PE32 > - @return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC - Image is PE32+ > - > -**/ > -VOID > -CreateHobList ( > - IN VOID *MemoryBegin, > - IN UINTN MemoryLength, > - IN VOID *HobBase, > - IN VOID *StackBase > - ); > - > - > /** > This service enables PEIMs to create various types of HOBs. > > diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c > index aff8ea05797b..ba16899a9184 100644 > --- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c > +++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c > @@ -175,47 +175,6 @@ BuildResourceDescriptorHob ( > Hob->ResourceLength = NumberOfBytes; > } > > -/** > - > - > -**/ > -VOID > -CreateHobList ( > - IN VOID *MemoryBegin, > - IN UINTN MemoryLength, > - IN VOID *HobBase, > - IN VOID *StackBase > - ) > -{ > - EFI_HOB_HANDOFF_INFO_TABLE *Hob; > - EFI_RESOURCE_ATTRIBUTE_TYPE Attributes; > - > - Hob = HobConstructor (MemoryBegin,MemoryLength,HobBase,StackBase); > - SetHobList (Hob); > - > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > - > - Attributes =( > - EFI_RESOURCE_ATTRIBUTE_PRESENT | > - EFI_RESOURCE_ATTRIBUTE_INITIALIZED | > - EFI_RESOURCE_ATTRIBUTE_TESTED | > - EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | > - EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | > - EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | > - EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE > - ); > - > - BuildResourceDescriptorHob (EFI_RESOURCE_SYSTEM_MEMORY, Attributes, (UINTN)MemoryBegin, MemoryLength); > - > - BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin + MemoryLength) - (UINTN)StackBase); > - > - if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) { > - // Optional feature that helps prevent EFI memory map fragmentation. > - BuildMemoryTypeInformationHob (); > - } > -} > - > - > VOID > EFIAPI > BuildFvHobs ( > -- > 2.19.1 >