From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 340072119680A for ; Thu, 29 Nov 2018 07:43:50 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r10so2360625wrs.10 for ; Thu, 29 Nov 2018 07:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3MgyXh8yjmVbs611qhjNMD7Kgdcl2NR8L9JD9jSSBQ4=; b=FYgaWzSxlZOQs1L93NYG09DIV+f36NgsjwT8nLlzxwUZiGguj4UCJ340O4a1IfjFIp +da2B+FbYcpod9GigjZZ/C+gZhDTbuqyh11hzZM83Sqk2BOiQVet34F48DTrQo7RTt4l QbUnpuhKHPUNPjQs+aDvN6dIM4pF9UI9W3I1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3MgyXh8yjmVbs611qhjNMD7Kgdcl2NR8L9JD9jSSBQ4=; b=OSIl/Lt7cdWmwp7vwCWmkobFbeYQt5rzE2/DrSbu6Gezcz7NjAez9DnsXW7hI4MzTm dqwCCsK+ne+uE6O/D2O0U5GVaCpIWLP9lQWZLy1IR6zJAhassGwG6S6pPe4sFOQs0hbb dNzHq339TIZ/4bMP+uz/XFgfdqxdCKH5/2Upe6ElggBbWDNkXCwNe4mESwYPdItQr9M6 YccOrwCvf4l7elOjwsWFRJnGYWIsNvY+/AWAdDnjo2+JqyTc4ikNMNyKgcPo5ubcJroV +sI9aT0ouAygtf9LcGphZtunUBtlh92cNuTsPJ9IIm5k0FVFAb8wi+z3y1UiA2i6JZlQ St/Q== X-Gm-Message-State: AA+aEWZfYkjoyFYwAg5/VSEH5d6E9oYdueFi6NHMFtT2xjptfwed3y1+ Xi8oPZqe0W0farsPHTig/O2uPnR8RVI= X-Google-Smtp-Source: AFSGD/V7u/97ci8ImjZNiPf4e5/ztX4uHpPlGTuyxWUrw1h7CopCKZTufw8jqRlp93CV9vUDFRw5og== X-Received: by 2002:adf:9287:: with SMTP id 7-v6mr1864205wrn.3.1543506228709; Thu, 29 Nov 2018 07:43:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q12sm2287906wrx.31.2018.11.29.07.43.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 07:43:47 -0800 (PST) Date: Thu, 29 Nov 2018 15:43:46 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Laszlo Ersek , Eric Auger , Andrew Jones , Philippe Mathieu-Daude , Julien Grall Message-ID: <20181129154346.eomeqwxjwdcqpayv@bivouac.eciton.net> References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-10-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181128143357.991-10-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 09/16] ArmPkg/CpuPei: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:43:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 03:33:50PM +0100, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/Drivers/CpuPei/CpuPei.inf | 1 - > ArmPkg/Drivers/CpuPei/CpuPei.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.inf b/ArmPkg/Drivers/CpuPei/CpuPei.inf > index eafccd600983..dcea012fd8f9 100644 > --- a/ArmPkg/Drivers/CpuPei/CpuPei.inf > +++ b/ArmPkg/Drivers/CpuPei/CpuPei.inf > @@ -50,7 +50,6 @@ [Guids] > gArmMpCoreInfoGuid > > [FixedPcd] > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > [Depex] > diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.c b/ArmPkg/Drivers/CpuPei/CpuPei.c > index d54f42acfcc8..e63519ff6481 100644 > --- a/ArmPkg/Drivers/CpuPei/CpuPei.c > +++ b/ArmPkg/Drivers/CpuPei/CpuPei.c > @@ -73,7 +73,7 @@ InitializeCpuPeim ( > ArmEnableBranchPrediction (); > > // Publish the CPU memory and io spaces sizes > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); > > // Only MP Core platform need to produce gArmMpCoreInfoPpiGuid > Status = PeiServicesLocatePpi (&gArmMpCoreInfoPpiGuid, 0, NULL, (VOID**)&ArmMpCoreInfoPpi); > -- > 2.19.1 >