From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 97E5A21196815 for ; Thu, 29 Nov 2018 07:44:17 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id j2so2390975wrw.1 for ; Thu, 29 Nov 2018 07:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2VZV/zs3BSynxk5xFJHJO2gFNgFBtqQ2kJWHoBVNPUA=; b=ZQdGID0wSSzFhkfHhHfYTl3ZC6qSHacnVSlDWatfEH5D4cd9YriWnMUJjYezHKTNsq iIzS+ZYRLUqPeSpbevOVNDbymX5hhbJLYMbjInKMsQEyFIkpHC09TA8UohEDpMdSeuHt mD/0bBHnJr17jLrj1EHcZacwA7sW5Ko9sjvSU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2VZV/zs3BSynxk5xFJHJO2gFNgFBtqQ2kJWHoBVNPUA=; b=mvIqGZzEf0rQ+dIdrm8JqiaXGmRTZQ9Wu3OOFZQalSyoKpkoHXpYOzi4ZL0tV3zoBq S+ez2+C1dav+jPe3DhAdkiS3tfLqJZR9WvC00HPnEkKayXRSQ0rmYKka2V39bpnOIQ51 /Nx4CK8JnCbfbPc4M16QvPuT/j4RAdijH9dHo7doMbUnYQtOgDbaAyfcOA9OcTtp9Whm +oWwsPpAEwQXNUquh6h3qXeeeFRxXC+gphF+VYsAK7/8EH5gdwRGcea0xKK7aXOjtCCh TH2Efvp0ZHRjrGjXdgB1IJl8D01uaQO58Jk2eFRqquZLCLAdkzwWhemMXRKPrdoJ8ENj zG1Q== X-Gm-Message-State: AA+aEWbvGzkVR3QjK4ARBrDkeKeVuBPHSA9zjboZj1fZMk5dXqTsZ+Q4 Xl/glkPIOK6nDP9Qk/8uCrldDA== X-Google-Smtp-Source: AFSGD/U0JPbQDftSCClCNc7jADdr61UUkbBjsmk1iqxPingfKk9K2ebhupQcUnqhSwnnge6PM8m2MQ== X-Received: by 2002:adf:f38f:: with SMTP id m15mr1849572wro.111.1543506256116; Thu, 29 Nov 2018 07:44:16 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v189-v6sm3939604wmd.40.2018.11.29.07.44.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 07:44:15 -0800 (PST) Date: Thu, 29 Nov 2018 15:44:13 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Laszlo Ersek , Eric Auger , Andrew Jones , Philippe Mathieu-Daude , Julien Grall Message-ID: <20181129154413.ooadlaxn5bq7aszu@bivouac.eciton.net> References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-11-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181128143357.991-11-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 10/16] ArmPlatformPkg/PrePi: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:44:18 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 03:33:51PM +0100, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 1 - > ArmPlatformPkg/PrePi/PeiUniCore.inf | 1 - > ArmPlatformPkg/PrePi/PrePi.c | 2 +- > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf > index 242b03175536..7e2ad6fc483d 100644 > --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf > +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf > @@ -97,7 +97,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf > index a45cdef4ed91..26328b7e8f67 100644 > --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf > +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf > @@ -90,7 +90,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c > index 02cff7ddc204..245bdded1eb3 100644 > --- a/ArmPlatformPkg/PrePi/PrePi.c > +++ b/ArmPlatformPkg/PrePi/PrePi.c > @@ -115,7 +115,7 @@ PrePiMain ( > BuildStackHob (StacksBase, StacksSize); > > //TODO: Call CpuPei as a library > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); > > if (ArmIsMpCore ()) { > // Only MP Core platform need to produce gArmMpCoreInfoPpiGuid > -- > 2.19.1 >