From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0165821196817 for ; Thu, 29 Nov 2018 07:44:54 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id k198so2720879wmd.3 for ; Thu, 29 Nov 2018 07:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=btR4pD3uaSBZLxbEo0d3kxItL3JYeqWAaUdJkVfAquo=; b=ZXOe3PZrrL+NtIa/pwk2AwqFePBlsS9X8R9yxqcoi6umGhul6UChsTuyzJ0VDY1rsb KnFayoG6ZJTkRZKcg6eYg9N642DPkYrca3bDq7DFVy6noozjKLk22YKVFExqINgQokle 3WXARKLKx4hk9lKjQVv+FLFxUdb1Na74ZsoW8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=btR4pD3uaSBZLxbEo0d3kxItL3JYeqWAaUdJkVfAquo=; b=lTgLeVfT7NdxoKPBq/w8dmDhEhI3r9eRizyi0ilIY8sawgh7QoIEuXOsR6NtGhMukq WETmY9ib1/FXeZKWWLW6cu/hckE9nqPu3WcSseajeHW3uuuU5xMLSyx9Lj4MaCQZhu9q WCXtV0zm6zhyIdyTP4urbzz7Lz7x9InPxXm2rAgkj7Q9XzqrwsBIuaaFpkV+pbhT0yHD id2JUDNbOHI59rX7HvcW0mJ7vMINPyWrChMC8yCO3Y/8gceMOr6YIIJ2sm1wW7frpEPj HvsgorPJJ3ejnusWRv7tWMgIXLOoVYicMrqq95YuhXh1CA7l+IJFQxc2kDS3nVPtht89 EpUg== X-Gm-Message-State: AA+aEWYcGGY2DGFI1OtR25gLPJWhffLMQffCpyXcZEOb4XIL8Ox00P06 /GykiW+Rr2FRVcHWb44/pwTf2A== X-Google-Smtp-Source: AFSGD/WVRGAffuaAsOXTylbYKiAhYihVI20H+VnppbzXrTcNJqgxDO/I9Ki+XNu9+YOVeCz+E/GG6A== X-Received: by 2002:a1c:7e8e:: with SMTP id z136mr2386749wmc.140.1543506293184; Thu, 29 Nov 2018 07:44:53 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t17sm2779026wme.43.2018.11.29.07.44.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 07:44:52 -0800 (PST) Date: Thu, 29 Nov 2018 15:44:50 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, Laszlo Ersek , Eric Auger , Andrew Jones , Philippe Mathieu-Daude , Julien Grall Message-ID: <20181129154450.st3awfjiugk2pc5d@bivouac.eciton.net> References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-13-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181128143357.991-13-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v3 12/16] BeagleBoardPkg/PrePi: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:44:55 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 28, 2018 at 03:33:53PM +0100, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > BeagleBoardPkg/PrePi/PeiUniCore.inf | 1 - > BeagleBoardPkg/PrePi/PrePi.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/BeagleBoardPkg/PrePi/PeiUniCore.inf b/BeagleBoardPkg/PrePi/PeiUniCore.inf > index 3d72bc5b46e1..53c71d8eafc2 100644 > --- a/BeagleBoardPkg/PrePi/PeiUniCore.inf > +++ b/BeagleBoardPkg/PrePi/PeiUniCore.inf > @@ -86,7 +86,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/BeagleBoardPkg/PrePi/PrePi.c b/BeagleBoardPkg/PrePi/PrePi.c > index 46f63f40c46e..bc9b0c80b84c 100644 > --- a/BeagleBoardPkg/PrePi/PrePi.c > +++ b/BeagleBoardPkg/PrePi/PrePi.c > @@ -110,7 +110,7 @@ PrePiMain ( > BuildStackHob (StacksBase, StacksSize); > > //TODO: Call CpuPei as a library > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); > > // Store timer value logged at the beginning of firmware image execution > Performance.ResetEnd = GetTimeInNanoSecond (StartTimeStamp); > -- > 2.19.1 >