From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.2.88; helo=eur02-ve1-obe.outbound.protection.outlook.com; envelope-from=achin.gupta@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E5EE2118F37F for ; Fri, 30 Nov 2018 15:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DmqcqPTrEIed/Fycr0sHlUkkxQpwPjn9/7vdGzFjkA4=; b=hRc+23n1IwzEmOMJPTWLpfztLOYNdjMeBZ7mGj3U4uYsmCquR5fWafBsXTr+RPVyZQGDcqFQVtpWnqDH9EqoECUEHHZbPZqG7PsRPInQaXo6inbuVeAurJm3dMPDTPdQ9hfmrvF2omNFHTDxsIFyuPvdijMs4B9z/B0KxFd5EOo= Received: from AM0PR08MB2980.eurprd08.prod.outlook.com (52.134.92.153) by AM0PR08MB3555.eurprd08.prod.outlook.com (20.177.110.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.20; Fri, 30 Nov 2018 23:38:51 +0000 Received: from AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::8908:b854:e03:a206]) by AM0PR08MB2980.eurprd08.prod.outlook.com ([fe80::8908:b854:e03:a206%4]) with mapi id 15.20.1382.020; Fri, 30 Nov 2018 23:38:51 +0000 From: Achin Gupta To: Sughosh Ganu CC: "edk2-devel@lists.01.org" , nd , "jiewen.yao@intel.com" Thread-Topic: [PATCH v2 0/2] StandaloneMM: Update permissions for Standalone MM drivers memory area Thread-Index: AQHUhhmsygXY/Z2Q0UC+ifQGwqy4+aVo/36A Date: Fri, 30 Nov 2018 23:38:50 +0000 Message-ID: <20181130233851.GS4897@e104320-lin> References: <1543299775-25345-1-git-send-email-sughosh.ganu@arm.com> In-Reply-To: <1543299775-25345-1-git-send-email-sughosh.ganu@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.5.21 (2010-09-15) x-originating-ip: [217.140.106.55] x-clientproxiedby: CWLP265CA0144.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:53::36) To AM0PR08MB2980.eurprd08.prod.outlook.com (2603:10a6:208:5b::25) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Achin.Gupta@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR08MB3555; 6:XgmczIEVD1VgjKoZAAs+S639hiQOwsGJG3wIFJTtzD46j5GNWUi/q9Abd81kWcyZLDnwuAmXvNzE1UNOaV2Yadn4Drb1zRX7N/ty5+iyOxitUEyQZ0Rl1QI54kmpcEcftMTY2X+h6D+RgdX6JyhNPthXo5Ev/Hu+NfTI+8ham/iJSpTOm/OIkl3lTHTQe3RPmuRsvy9VQ6EOJRDlKbOIei1u1ga+G4X+PV7Audfkcyyg5bZI/4PHhS5kap6gLBfhM4/adRuE5M7aHlcp++GY/FCbQllQC0R6DI439SrllROuAjYons/6fqcbwkSwrXe3WxarxMrlLbbgdmhvcphprlXi25IL+hABTSlnLNgYZypU9u4opHr2x3wEL26aNln2oQpIWvVcdAlm8BqKUYnOGQ52KYVr2p+y73fnFaDpcz15XIA94BmD09X34038zg4jrUq9+RK0jCPdQ41joHmXlw==; 5:5l30+DJ+6daF7EleGguAASSd9AkU9reGIBCdAjeaNivQJ/P+sA1YmbcSpUjI9rlE5gIPAV2rE97UXuPzdILpBbon74Bra9z1P2xWwOx85lMyjsHUZLps8sD6bqfUgUYcFjqkKHr79z9Q1tzBCMHMQv6PiHn5qKki1F6hF25+uWM=; 7:ThsoWcJ5CoR2ZcDbb4ATGjhBLAx5hGsJwfL9lpZDFeBjY4D/EJhWk9ibC6fPzMruzBQUTgaEBIxNmLohQe7UMGtrroFHsDx8S+AhPe3xymrmN88tFbAHjnoOACodEEDVcfnwxYxqNKnp1lLMCaYpCg== x-ms-office365-filtering-correlation-id: f6f111b4-1480-4a96-2c3a-08d6571cfb51 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB3555; x-ms-traffictypediagnostic: AM0PR08MB3555: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231453)(999002)(944501470)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM0PR08MB3555; BCL:0; PCL:0; RULEID:; SRVR:AM0PR08MB3555; x-forefront-prvs: 087223B4DA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(376002)(136003)(396003)(346002)(366004)(39860400002)(199004)(189003)(19627235002)(486006)(86362001)(316002)(44832011)(33656002)(68736007)(99286004)(14454004)(6512007)(305945005)(9686003)(6246003)(6636002)(26005)(7736002)(476003)(11346002)(66066001)(6862004)(71200400001)(4326008)(3846002)(2906002)(71190400001)(1076002)(81156014)(52116002)(478600001)(256004)(8936002)(81166006)(14444005)(54906003)(58126008)(53936002)(6436002)(102836004)(186003)(15650500001)(386003)(33896004)(25786009)(33716001)(97736004)(72206003)(6506007)(6486002)(6116002)(105586002)(106356001)(5660300001)(446003)(76176011)(229853002)(8676002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3555; H:AM0PR08MB2980.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Ud6YH/cceOAUAjvEEv+D8avvZ9MQLtkywN7ZiaUgJ5OK1V7fHSuO5nGD4beEo6JcRy0r/hK0CY4sUxYkkml/Ep0LG0b7B473GAZcfSU4zulPYF/GjG9uh6tm1geW87+WcLTff+rqU2HT8g6QJ3Z78oIZwXzzW9rWjf2shct5SXmDOkqOyxMPTn0XyjpChhw8auM6hFyAIsLbDEWUNze/rPFCarIg7X7yTGpB48P1aWLbUeGWqSRCAllMcLAdrbl9uIQR1S902giFuTx2rAdeWwQHBZ4kRdvaKkDeYMv3UMfH/L1ipYnXEntsrvLVbW6jHzABsum0v5ghiMLm8pS5hbGqRW66/KjpLFB3tgWvPas= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6f111b4-1480-4a96-2c3a-08d6571cfb51 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2018 23:38:50.9187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3555 Subject: Re: [PATCH v2 0/2] StandaloneMM: Update permissions for Standalone MM drivers memory area X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 23:38:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <5D222486B057964A912D599D6862ED25@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable Hi Sughosh, +Jiewen I took the patches for a spin and it looks like the FVP port is broken. Som= e reasons are: 1. The build breaks due to a reference to ArmMmuLib in StandaloneMmPkg.dsc 2. There is a broken dependency on PL011UartClockLib in StandaloneMmPkg.dsc 3. GCC flags to enforce strict alignment and no fp are required in StandaloneMmPkg.dsc to avoid a runtime fault 4. There is a data structre in StandaloneMmCoreEntryPoint.c that needs to b= e memzeroed due to the alignment checks Even after these fixes, I am unable to boot the MM SP. The SP boots with th= e previous revision of your patches and the above fixes. Something has broken between the two. I am suspecting the MMU library for S-EL0. Lets sort this out first. Apart from this, could you move this library into an AArch64 directory as is the case for other Arm specific libraries e.g. StandaloneMmCoreEntryPoint/AArch64 cheers, Achin On Tue, Nov 27, 2018 at 11:52:53AM +0530, Sughosh Ganu wrote: > Changes since v1: > A new patch has been added to reflect the library class added for > changing the MMU attributes in StandaloneMM image, based on review > comments from Ard Biesheuvel. >=20 >=20 > These patches needs to be applied on top of the following patch series > - "ArmPkg related changes for StandaloneMM package". >=20 >=20 > Sughosh Ganu (2): > StandaloneMM: Include the newly added library class for MMU functions > StandaloneMM: Update permissions for Standalone MM drivers memory area >=20 > .../StandaloneMmCoreEntryPoint.inf | 2 +- > .../StandaloneMmPeCoffExtraActionLib.inf | 18 +- > .../StandaloneMmPeCoffExtraActionLib.c | 222 +++++++++++++++= ++++++ > 3 files changed, 234 insertions(+), 8 deletions(-) > copy ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf = =3D> StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/StandaloneMmP= eCoffExtraActionLib.inf (72%) > create mode 100644 StandaloneMmPkg/Library/StandaloneMmPeCoffExtraAction= Lib/StandaloneMmPeCoffExtraActionLib.c >=20 > --=20 > 2.7.4 >=20