[edk2-test][v2 Patch 0/3] Add VerifySignature() Test

[edk2-test][v2 Patch 0/3] Add VerifySignature() Test

[Eric Jin]

This is the cover letter.
The series of patches are listed below.

  uefi-sct/SctPkg:Format code style in PKCS7Verify
  uefi-sct/SctPkg:Add VerifySignature() Func Test
  uefi-sct/SctPkg:Add VerifySignature() Conf Test


 .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.c   |   93 +-
 .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.h   |  192 +--
 .../PKCS7Verify/BlackBoxTest/Pkcs7BBTest.inf       |  126 +-
 .../BlackBoxTest/Pkcs7BBTestConformance.c          | 1305 +++++++++-------
 .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestData.c     | 1568 +++++++++++++-------
 .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestFunction.c |  553 ++++---
 .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.c     |  458 +++---
 .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.h     |  248 ++--
 8 files changed, 2689 insertions(+), 1854 deletions(-)

-- 
2.9.0.windows.1

Re: [edk2-test][v2 Patch 0/3] Add VerifySignature() Test

[Laszlo Ersek]

On 12/03/18 08:53, Eric Jin wrote:
> This is the cover letter.
> The series of patches are listed below.
> 
>   uefi-sct/SctPkg:Format code style in PKCS7Verify
>   uefi-sct/SctPkg:Add VerifySignature() Func Test
>   uefi-sct/SctPkg:Add VerifySignature() Conf Test
> 
> 
>  .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.c   |   93 +-
>  .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.h   |  192 +--
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTest.inf       |  126 +-
>  .../BlackBoxTest/Pkcs7BBTestConformance.c          | 1305 +++++++++-------
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestData.c     | 1568 +++++++++++++-------
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestFunction.c |  553 ++++---
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.c     |  458 +++---
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.h     |  248 ++--
>  8 files changed, 2689 insertions(+), 1854 deletions(-)
> 

A cover letter like this doesn't make any sense.

- Please enable shallow threading for git-send-email, so that the patch
emails are (direct) children of the cover letter. One of the goals of
the cover letter is to group the patches under a common parent message.

- The other purpose of cover letters is to summarize the goal of the
patch series (high level problem statement, chosen solution, maybe
mention one or two details if they are important).

Thanks
Laszlo

Re: [edk2-test][v2 Patch 0/3] Add VerifySignature() Test

[Jin, Eric]

Hi Laszlo,

Thank for the comments. Will send out new patch series later. 

Best Regards
Eric

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com> 
Sent: Monday, December 3, 2018 9:50 PM
To: Jin, Eric <eric.jin@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [edk2-test][v2 Patch 0/3] Add VerifySignature() Test

On 12/03/18 08:53, Eric Jin wrote:
> This is the cover letter.
> The series of patches are listed below.
> 
>   uefi-sct/SctPkg:Format code style in PKCS7Verify
>   uefi-sct/SctPkg:Add VerifySignature() Func Test
>   uefi-sct/SctPkg:Add VerifySignature() Conf Test
> 
> 
>  .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.c   |   93 +-
>  .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.h   |  192 +--
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTest.inf       |  126 +-
>  .../BlackBoxTest/Pkcs7BBTestConformance.c          | 1305 +++++++++-------
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestData.c     | 1568 +++++++++++++-------
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestFunction.c |  553 ++++---
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.c     |  458 +++---
>  .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.h     |  248 ++--
>  8 files changed, 2689 insertions(+), 1854 deletions(-)
> 

A cover letter like this doesn't make any sense.

- Please enable shallow threading for git-send-email, so that the patch emails are (direct) children of the cover letter. One of the goals of the cover letter is to group the patches under a common parent message.

- The other purpose of cover letters is to summarize the goal of the patch series (high level problem statement, chosen solution, maybe mention one or two details if they are important).

Thanks
Laszlo