From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6F30621198CCA for ; Tue, 4 Dec 2018 04:58:13 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r10so15821745wrs.10 for ; Tue, 04 Dec 2018 04:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YPRXcqyQqbQU4WRGG/nPU/FmAI8t8U8UuCqhq5STzkk=; b=IgL8a8rFuwiV9HWrUHJIqOiFnXTm4vW+e41Vlu+hhuL9DRDbFmZiOlrYg/5yPi9ny2 djujvvEqixYb4J+1MJuDWtNDnseqo8Yim7nj4xAoDmv+L9g1CggVlE4GxMny4rdRNRCN 83yH+9jE33+YKpDpaFzw9r6EEdkX0LfF+7M1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YPRXcqyQqbQU4WRGG/nPU/FmAI8t8U8UuCqhq5STzkk=; b=rPGq/drt6yjQv/YpUPyWCnBm+HL9C/p3aJ3qVpMZ8oG7BduL9aIIy5gsWZO//BV0lp 6jc85Ys1+I/gZFTP3NDGTApN/YX/kBSrECOM4iGrmlqmzuq2+f2e7DUocZ/5ORzBWi5a yQnvij4sWSoF/j1bhwS4GLP80eWgzDKj3rEPgilrf2m9ZZo/f/yhuZXwNrWojkCklzgn 5Mbhdn35wH6mnfzN48Wz93Rm2zj8XxJ0BQIZ0K5MrYBv31Oy2dgK5oqK/OAVQXbzn+UF TFaxnDsOkkuaqgL6Yf1hL51+6dsvRbNK8EC1UnAUHO5SXZMu+Oy63Vu6v2Chhh0SOGqv xCzg== X-Gm-Message-State: AA+aEWbxKsObUXEmDtPIDZFlsQewYW+ZiCrakO2Fa+oJ9ZOSlQPXvFTm 7MBEWQYDSYqKpX0fRLY1mKt6hw== X-Google-Smtp-Source: AFSGD/XIYN9iL2ENlciwnrGyy6ribKdbdePP6c0OBJXRVmjDDN+YejWkp2qBJrnXO7RyUH9lQQIKVA== X-Received: by 2002:adf:9d08:: with SMTP id k8mr19113524wre.203.1543928291618; Tue, 04 Dec 2018 04:58:11 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n12-v6sm7232447wmi.1.2018.12.04.04.58.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Dec 2018 04:58:10 -0800 (PST) Date: Tue, 4 Dec 2018 12:58:08 +0000 From: Leif Lindholm To: Chris Co Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Message-ID: <20181204125808.tnygscrdqgttgzpp@bivouac.eciton.net> References: <20180921082542.35768-1-christopher.co@microsoft.com> <20180921082542.35768-15-christopher.co@microsoft.com> <20181108181423.zpt4mivpcnd7w4cs@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 14/27] Silicon/NXP: Add i.MX6 GPT and EPIT timer headers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 12:58:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 04, 2018 at 02:06:04AM +0000, Chris Co wrote: > > > diff --git a/Silicon/NXP/iMX6Pkg/Include/common_epit.h > > > b/Silicon/NXP/iMX6Pkg/Include/common_epit.h > > > new file mode 100644 > > > index 000000000000..485d6ccbc51e > > > --- /dev/null > > > +++ b/Silicon/NXP/iMX6Pkg/Include/common_epit.h > > > > Rename to CamelCase? > > Can do. Would you prefer the iMX prefix to be in CamelCase too? (i.e. Imx6Epit.h) I'm honestly not too fussed. My preference (which contradicts the coding style, mind you) is to keep names looking like they do in normal reading. So I would aesthetically prefer the former, whereas the coding style says the latter. You choose :) / Leif