From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D51CA211958E1 for ; Tue, 4 Dec 2018 07:23:20 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id 96so16409808wrb.2 for ; Tue, 04 Dec 2018 07:23:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V3LAslBNMIDffXyCrjE9KNEymUzMN6DcYBGQkKYqkZ0=; b=LJRkShDsEZ2RBRQ25I/EhLSa1s7fpiSvLhwzXcgdk7smlh6LrtXD2vm3YEBu0lkbDa dKFco6EaO3TnA++SGL86h/sh/1CedJiddUjfQTB/G1SlMjs+r2tVLcYcrvzVtQaoqXQl bXbaB38B5bllnLKJif3ZMmn0iYhYulQMGikqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V3LAslBNMIDffXyCrjE9KNEymUzMN6DcYBGQkKYqkZ0=; b=EsKz6vwqYxLfgKAnXzYzjJQvr/ddTUIHvx7FHCGBAkgvHM1wEcCzxm/hEhIFUKGEyM iFZFvM+b1xH4v2ZLLYU20kgFdnGDZwi4NmOBr3ndZe3vgCMy131yK8p8YqF4021HgjQX Uv8d8iUGfSRkyJx9YCedq3Xde6Mum+H0nGjRxcd3fCipIUaxk0MDRTDJK2a6L29Myl1C xpIXLNlqJrbDSwGXSvhnTqKiIBVS5PgswhyVQfZR6nPJVFpOUD6V/tNQUytIGr+tgLO4 0KZAOCYb5BuwYiD4d4++lBPyJRKVGLT3Jy6GxPw1KHnD9DiqyJCy2HZqy/iIdZSEAoEd /3jg== X-Gm-Message-State: AA+aEWY10vNqSRfjd/OC6cfUkN4CQq7pTQGRzV6kqQyBVDFob+J4p0Cq R3IU7YuJf8bpTPMkAlGsfwxvIg== X-Google-Smtp-Source: AFSGD/X5Aj9LZn0dvlEr0co2NdrPHpSqrKVoPxq7Ismg1neLZMwt8A6YUtYxFzV+FT7mqmWQc+QipA== X-Received: by 2002:a5d:4286:: with SMTP id k6mr18426466wrq.225.1543936999095; Tue, 04 Dec 2018 07:23:19 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h131sm14921005wmd.17.2018.12.04.07.23.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Dec 2018 07:23:18 -0800 (PST) Date: Tue, 4 Dec 2018 15:23:16 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20181204152316.do3yiheejk6coxqz@bivouac.eciton.net> References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-4-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1540000661-1956-4-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 03/12] SolidRun/Armada80x0McBin: Introduce board description library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 15:23:21 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 20, 2018 at 03:57:32AM +0200, Marcin Wojtas wrote: > This patch implements ArmadaBoarDescLib library for > Armada80x0McBin comunity board and introduces ArmadaBoardDescGpioGet > routine with per-board I2C IO expander description. I would argue it "adds an implementation" rather than "introduces" (2/12 did that). Also, since there _is_ no expansion here, the referring to it as I2C gets ever weirder. No issues beyond such nitpicking: if you address the commit message and purge all mentions of I2C from this patch: Reviewed-by: Leif Lindholm > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 3 ++ > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf | 34 ++++++++++++++++++ > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 36 ++++++++++++++++++++ > 3 files changed, 73 insertions(+) > create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c > > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > index 52e2b9b..077224d 100644 > --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > @@ -55,6 +55,9 @@ > [Components.AARCH64] > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf > > +[LibraryClasses.common] > + ArmadaBoardDescLib|Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > + > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > new file mode 100644 > index 0000000..63a4f66 > --- /dev/null > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf > @@ -0,0 +1,34 @@ > +## @file > +# > +# Copyright (C) 2018, Marvell International Ltd. and its affiliates
> +# > +# This program and the accompanying materials are licensed and made available > +# under the terms and conditions of the BSD License which accompanies this > +# distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > +# IMPLIED. > +# > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = ArmadaMcBinBoardDescLib > + FILE_GUID = 8208558f-5f33-46e2-b5c5-43354384389e > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = ArmadaBoardDescLib > + > +[Sources] > + Armada80x0McBinBoardDescLib.c > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Silicon/Marvell/Marvell.dec > + > +[LibraryClasses] > + DebugLib > + IoLib > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c > new file mode 100644 > index 0000000..979db11 > --- /dev/null > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c > @@ -0,0 +1,36 @@ > +/** > +* > +* Copyright (C) 2018, Marvell International Ltd. and its affiliates. > +* > +* This program and the accompanying materials are licensed and made available > +* under the terms and conditions of the BSD License which accompanies this > +* distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +EFI_STATUS > +EFIAPI > +ArmadaBoardDescGpioGet ( > + IN OUT MV_I2C_IO_EXPANDER_DESC **I2cIoExpanderDesc, > + IN OUT UINTN *I2cIoExpanderCount > + ) > +{ > + /* No I2C IO expanders on board */ > + *I2cIoExpanderDesc = NULL; > + *I2cIoExpanderCount = 0; > + > + return EFI_SUCCESS; > +} > -- > 2.7.4 >