From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E75D921196236 for ; Wed, 5 Dec 2018 12:10:54 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id u3so20992534wrs.3 for ; Wed, 05 Dec 2018 12:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fBFSHCwmkWROSCRQOJFsg9ZvX1nhJFFs6bwAXP+GUzg=; b=GTwSdewZj4MExKG1HQa8iH9/ibcNDF23IsEhqiYOv3xuVBdBtont0d21hAT7HrpZNm wSD6ltEr5GkuhvWrjiGNst5n6xFnQbf7rdkSlyLpwxN1T7S/Df0h8yUV/bq0iOlu4xpW Nd6ypsL26AiwuI9MetETGs2V58H6X79tWiz1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fBFSHCwmkWROSCRQOJFsg9ZvX1nhJFFs6bwAXP+GUzg=; b=ttTdRkrw1K85gUK68f0LbAGooKjOmrRxvhDbu/UCH2JfTbfIwK803QE0NzJV6zByTk 5wshR332sKieolfagx2uJAEBJyLgxx+V4Uiv3dStlq1RVITy7HSpd6H5Pz/9e+Q/62iM ok5liZd3c3s61xY7QDMWTJlEnE365lTgUkzyQ+QHQc6DSuXpJ1ZofekT2+4ITLPOM5uH e62pJH0x5OT/yXJIdKDRfe7oYd1mK3HTNKGSo+6GcbcFsBTBKkiSvq37OC6ZU9ugQJi7 lIu7AMLDRjGiyy2aeCSYfMFe9sbaQSs39Vh6Sughz+UqOEfaF2qw+KmlYsEooRIaSljk sCDQ== X-Gm-Message-State: AA+aEWY7F2yadoGQVvE8GTzWPLBXvhAporR7FfWDsfQNGj8/hJhdBYEs dqYJ+mYUXBgSGT0TnjJXhIqVf429dRC3bQ== X-Google-Smtp-Source: AFSGD/VfsslPy+4L+/Zqttp1oFF2erGE1B1ui1lCwQ2K6xXCq2wK2iYb9RlJ09XuiOHavnr1PJVAGw== X-Received: by 2002:adf:db51:: with SMTP id f17mr21574042wrj.90.1544040652668; Wed, 05 Dec 2018 12:10:52 -0800 (PST) Received: from harold.home ([2a01:cb1d:112:6f00:2077:9cc7:ca9:e4e7]) by smtp.gmail.com with ESMTPSA id t76sm28115491wme.33.2018.12.05.12.10.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 12:10:51 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 5 Dec 2018 21:10:48 +0100 Message-Id: <20181205201049.10590-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 20:10:55 -0000 Content-Transfer-Encoding: 8bit The PCDs containing the default MAC addresses are of type UINT64, and so the byte order needs to be inverted. As they are currently, both default MAC addresses are invalid since they have the multicast bit set. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc index 05433d4472e8..2843e51f93f7 100644 --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc @@ -469,8 +469,8 @@ DEFINE DO_CAPSULE = FALSE gAmdModulePkgTokenSpaceGuid.PcdPort1NetSpeed|1 [PcdsDynamicDefault.common] - gAmdStyxTokenSpaceGuid.PcdEthMacA|0x02A1A2A3A4A5 - gAmdStyxTokenSpaceGuid.PcdEthMacB|0x02B1B2B3B4B5 + gAmdStyxTokenSpaceGuid.PcdEthMacA|0xA5A4A3A2A102 + gAmdStyxTokenSpaceGuid.PcdEthMacB|0xB5B4B3B2B102 [PcdsPatchableInModule] gAmdModulePkgTokenSpaceGuid.PcdXgbeUseMacFromIscp|TRUE -- 2.19.2