public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data
@ 2018-12-08 10:24 Ard Biesheuvel
  2018-12-10 12:25 ` Leif Lindholm
  2018-12-11  1:48 ` Wu, Hao A
  0 siblings, 2 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2018-12-08 10:24 UTC (permalink / raw)
  To: edk2-devel; +Cc: jian.j.wang, hao.a.wu, ruiyu.ni, Ard Biesheuvel

Struct packing is only necessary for data structures whose in-memory
representation is covered by the PI or UEFI specs, and may deviate
from the ordinary C rules for alignment.

So in case of FileExplorerLib, this applies to the device path struct
only, and other structures used to carry program data should not be
packed, or we may end up with alignment faults on architectures such
as ARM, which don't permit load/store double or multiple instructions
to access memory locations that are not 32-bit aligned.

E.g., the following call in FileExplorerLibConstructor()

  InitializeListHead (&gFileExplorerPrivate.FsOptionMenu->Head);

which is emitted as follows for 32-bit ARM/Thumb2 by Clang-5.0

    3de0:       b510            push    {r4, lr}
    3de2:       4604            mov     r4, r0
    ...
    3de8:       e9c4 4400       strd    r4, r4, [r4]
    3dec:       bd10            pop     {r4, pc}

will perform a double-word store on the first argument, passed in
register r0, assuming that the pointer type of the argument is
enough to guarantee that the value is suitably aligned.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 MdeModulePkg/Library/FileExplorerLib/FileExplorer.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorer.h b/MdeModulePkg/Library/FileExplorerLib/FileExplorer.h
index bf1450dbd581..603185abe4b1 100644
--- a/MdeModulePkg/Library/FileExplorerLib/FileExplorer.h
+++ b/MdeModulePkg/Library/FileExplorerLib/FileExplorer.h
@@ -51,6 +51,8 @@ typedef struct {
   EFI_DEVICE_PATH_PROTOCOL       End;
 } HII_VENDOR_DEVICE_PATH;
 
+#pragma pack()
+
 typedef struct {
   EFI_HANDLE                        DeviceHandle;
   EFI_DEVICE_PATH_PROTOCOL          *DevicePath;
@@ -100,8 +102,6 @@ typedef struct {
 
 #define FILE_EXPLORER_PRIVATE_FROM_THIS(a)  CR (a, FILE_EXPLORER_CALLBACK_DATA, FeConfigAccess, FILE_EXPLORER_CALLBACK_DATA_SIGNATURE)
 
-#pragma pack()
-
 extern UINT8    FileExplorerVfrBin[];
 
 #define MENU_OPTION_SIGNATURE      SIGNATURE_32 ('m', 'e', 'n', 'u')
-- 
2.19.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-11 12:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08 10:24 [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data Ard Biesheuvel
2018-12-10 12:25 ` Leif Lindholm
2018-12-10 14:39   ` Gao, Liming
2018-12-10 15:01     ` Leif Lindholm
2018-12-11  1:48 ` Wu, Hao A
2018-12-11 12:15   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox