From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Laszlo Ersek (lersek@redhat.com)" <lersek@redhat.com>,
"afish@apple.com" <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Rebecca Cran <rebecca@bluestop.org>
Subject: Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template
Date: Mon, 10 Dec 2018 11:56:50 +0000 [thread overview]
Message-ID: <20181210115650.rr566vwiynd4en5j@bivouac.eciton.net> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E384E67@SHSMSX104.ccr.corp.intel.com>
On Thu, Dec 06, 2018 at 02:42:35PM +0000, Gao, Liming wrote:
> Hi, all
> tools_def.template includes all tool chains. Some are not used any
> more. And, there is no verification for them. So, I propose to
> remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
> UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
> MYTOOLS. If you still use some one of them, please let me know.
This sounds good to me.
However, may I suggest splitting this up into several patches, such
that if we need to revert one of the deletions, we would not need to
reinstate all of them.
I would propose:
- One patch for VS20nn
- One patch for GCCnn
- One patch for UNIXGCC, ELFGCC, CYGGCC
I can't really judge what a suitable mashup/split between DDK3790,
ICC, ICC11, and MYTOOLS would be.
On a sidenote, I think Rebecca said at least FreeBSD were using
UNIXGCC(?) since the plain GCC toolchain profiles did not support
cross compiling. I am pretty sure that is not accurate these days -
did you look into that after the community call?
Regards.
Leif
next prev parent reply other threads:[~2018-12-10 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 14:42 [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template Gao, Liming
2018-12-06 15:42 ` Laszlo Ersek
2018-12-06 22:14 ` Ard Biesheuvel
2018-12-10 11:56 ` Leif Lindholm [this message]
2018-12-10 12:38 ` Gao, Liming
2018-12-11 7:03 ` David F.
2018-12-12 1:02 ` Hiber He
2018-12-12 14:17 ` Gao, Liming
-- strict thread matches above, loose matches on Subject: below --
2019-04-16 1:43 Zhang, Shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210115650.rr566vwiynd4en5j@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox