From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F29652119A847 for ; Mon, 10 Dec 2018 10:57:31 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c14so11655785wrr.0 for ; Mon, 10 Dec 2018 10:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j4dE+EO6wWRW8QnwbBAecoVIHEVvUqwzEDEljJ1gco0=; b=b4HOORtz2cpgDLVFrmv+RGGU2Cbh+ZL8oaGI6eMuO1SJuHrz00OaTd7WkhujkRkyFd 79KtYZsAT6ACpVO2LYfH8sjjo09YWoO4zmLpcYk+QXzTNR1Mux15Kafjx5NIx0mbNOH9 BmNB3cJxMn031TFNIUAgIP+HFR3H0z5+cBxg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j4dE+EO6wWRW8QnwbBAecoVIHEVvUqwzEDEljJ1gco0=; b=G1Dnkj/P/0ql3NTh/IQ4x9YxdTptVrite/Kth3isWSgU/kJvQ8/h0fXYL25sA7ws+L AfbAxYncR/vx5o0Ty1BzbwpXThPWEMAGkUcri3Dm8OfRUCprArBEl5xtVXGItEnrl5fy mOrJK4fRYRE222bwkLaWIxM3WAwVSKw0617hdWB129f9osf3/7K2L0i0VMIs8QNQOM8O TvbnGt9L31DtpX70rvbOr0Okndki+bm4LRmUwhJQpQOmLgY+DI+aIPOMcFesjZECPUIm +Zf81lBI1uB+na/vB89dTgwFSAhjdqiPf4e9K0pVXJ3SIH3c0/4VWuLVOvOz133NzU7O r/vA== X-Gm-Message-State: AA+aEWZBiq9LwCYdvcnI1VP/4pXdwadQlzvLjO70Jy7+Bou0SPW4h3b8 +bEaFhHtKW8fb0uogbQdvpGOJg== X-Google-Smtp-Source: AFSGD/UsEKS7kiuaDHHZrEBuDIMjGFERmZD/oQqZBYs/0PAjrmjo8R/fXiXMN+qLu0j9QCUL3IYybA== X-Received: by 2002:adf:8323:: with SMTP id 32mr10407670wrd.176.1544468248857; Mon, 10 Dec 2018 10:57:28 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y13sm13403453wrw.85.2018.12.10.10.57.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 10:57:28 -0800 (PST) Date: Mon, 10 Dec 2018 18:57:26 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, Jaben Carsey , Ruiyu Ni , Ard Biesheuvel , Shenglei Zhang Message-ID: <20181210185726.grk3rrbbekntreeu@bivouac.eciton.net> References: <20181115074528.8024-1-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20181115074528.8024-1-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ShellPkg: Remove ShellPkg wrapper header files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 18:57:32 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Marcin, This EDK2 patch has been pushed, making all of the Armada platforms stop building. Can you have a look please? Regards, Leif On Thu, Nov 15, 2018 at 03:45:28PM +0800, Shenglei Zhang wrote: > These wrapper header files are not referenced by all > open source, so they are removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=158 > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Include/Protocol/EfiShell.h | 21 ------------------- > .../Include/Protocol/EfiShellDynamicCommand.h | 21 ------------------- > .../Include/Protocol/EfiShellParameters.h | 20 ------------------ > ShellPkg/Include/ShellBase.h | 20 ------------------ > 4 files changed, 82 deletions(-) > delete mode 100644 ShellPkg/Include/Protocol/EfiShell.h > delete mode 100644 ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > delete mode 100644 ShellPkg/Include/Protocol/EfiShellParameters.h > delete mode 100644 ShellPkg/Include/ShellBase.h > > diff --git a/ShellPkg/Include/Protocol/EfiShell.h b/ShellPkg/Include/Protocol/EfiShell.h > deleted file mode 100644 > index 8e3c2fe4de..0000000000 > --- a/ShellPkg/Include/Protocol/EfiShell.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/** @file > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification including errata. > - > - (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ > -#define __EFI_SHELL_PROTOCOL_H__WRAPPER__ > - > -#include > - > -#endif > diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > deleted file mode 100644 > index 50f9398ec6..0000000000 > --- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h > +++ /dev/null > @@ -1,21 +0,0 @@ > -/** @file > - EFI Shell Dynamic Command registration protocol > - > - (C) Copyright 2012-2014 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > -#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ > - > -#include > - > -#endif > diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h b/ShellPkg/Include/Protocol/EfiShellParameters.h > deleted file mode 100644 > index 184b029ffa..0000000000 > --- a/ShellPkg/Include/Protocol/EfiShellParameters.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/** @file > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification. > - > - Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > -#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ > - > -#include > - > -#endif > diff --git a/ShellPkg/Include/ShellBase.h b/ShellPkg/Include/ShellBase.h > deleted file mode 100644 > index 725ce5242f..0000000000 > --- a/ShellPkg/Include/ShellBase.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/** @file > - Root include file for Shell Package modules that utilize the SHELL_RETURN type > - > - Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef _SHELL_BASE_ > -#define _SHELL_BASE_ > - > -#include > - > -#endif //__SHELL_BASE_ > -- > 2.18.0.windows.1 >