From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, alan@softiron.co.uk, graeme.gregory@linaro.org
Subject: Re: [PATCH edk2-platforms 0/6] Styx: fixes for IASL abuse and more
Date: Mon, 10 Dec 2018 21:58:23 +0000 [thread overview]
Message-ID: <20181210215823.nxk2z3qpqrcce63v@bivouac.eciton.net> (raw)
In-Reply-To: <20181205185020.21441-1-ard.biesheuvel@linaro.org>
On Wed, Dec 05, 2018 at 07:50:14PM +0100, Ard Biesheuvel wrote:
> Primarily, this series gets rid of the hacked up way this platform
> patches the DSDT at build time, by #include'ing intermediate output
> of the iasl compiler [or some version of it, at least]
>
> While at it, apply some other cleanups/improvements.
All but the last one seem like they're following some form of common
thread. But anyway:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Ard Biesheuvel (6):
> Silicon/AMD/Styx: move SOC version macros to common header
> Silicon/AMD/Styx: move B1 revision peripherals to separate SSDT table
> Silicon/AMD/Styx: move XGBE declarations to separate SSDT table
> Silicon/AMD/Styx: emit DSDT as aml directly
> Platform: add acpiview to Seattle/Styx platforms
> Platform/AMD/OverdriveBoard: use default resolution for GOP
>
> .../AMD/OverdriveBoard/OverdriveBoard.dsc | 7 +-
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 +-
> .../Overdrive1000Board/Overdrive1000Board.dsc | 4 +-
> .../AMD/OverdriveBoard/OverdriveBoard.fdf | 2 +-
> Platform/LeMaker/CelloBoard/CelloBoard.fdf | 2 +-
> .../Overdrive1000Board/Overdrive1000Board.fdf | 2 +-
> Silicon/AMD/Styx/AcpiTables/AcpiAml.inf | 29 ---
> Silicon/AMD/Styx/AcpiTables/AcpiTables.inf | 3 -
> .../AcpiPlatformDxe/AcpiPlatformDxe.inf | 13 ++
> Silicon/AMD/Styx/Common/AmdStyxAcpiLib.h | 1 -
> Silicon/AMD/Styx/Common/SocVersion.h | 19 ++
> Silicon/AMD/Styx/AcpiTables/Dsdt.c | 192 ------------------
> Silicon/AMD/Styx/AcpiTables/Iort.c | 6 +-
> .../Drivers/AcpiPlatformDxe/AcpiPlatform.c | 137 ++++++++++++-
> .../StyxSataPlatformDxe/InitController.c | 7 +-
> .../StyxDtbLoaderLib/StyxDtbLoaderLib.c | 7 +-
> .../AcpiPlatformDxe}/Dsdt.asl | 180 ----------------
> .../Styx/Drivers/AcpiPlatformDxe/SsdtB1.asl | 86 ++++++++
> .../Styx/Drivers/AcpiPlatformDxe/SsdtXgbe.asl | 135 ++++++++++++
> 19 files changed, 395 insertions(+), 442 deletions(-)
> delete mode 100644 Silicon/AMD/Styx/AcpiTables/AcpiAml.inf
> create mode 100644 Silicon/AMD/Styx/Common/SocVersion.h
> delete mode 100644 Silicon/AMD/Styx/AcpiTables/Dsdt.c
> rename Silicon/AMD/Styx/{AcpiTables => Drivers/AcpiPlatformDxe}/Dsdt.asl (72%)
> create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtB1.asl
> create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtXgbe.asl
>
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-10 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 18:50 [PATCH edk2-platforms 0/6] Styx: fixes for IASL abuse and more Ard Biesheuvel
2018-12-05 18:50 ` [PATCH edk2-platforms 1/6] Silicon/AMD/Styx: move SOC version macros to common header Ard Biesheuvel
2018-12-05 18:50 ` [PATCH edk2-platforms 2/6] Silicon/AMD/Styx: move B1 revision peripherals to separate SSDT table Ard Biesheuvel
2018-12-05 18:50 ` [PATCH edk2-platforms 3/6] Silicon/AMD/Styx: move XGBE declarations " Ard Biesheuvel
2018-12-05 18:50 ` [PATCH edk2-platforms 4/6] Silicon/AMD/Styx: emit DSDT as aml directly Ard Biesheuvel
2018-12-05 18:50 ` [PATCH edk2-platforms 5/6] Platform: add acpiview to Seattle/Styx platforms Ard Biesheuvel
2018-12-05 21:39 ` Carsey, Jaben
2018-12-05 18:50 ` [PATCH edk2-platforms 6/6] Platform/AMD/OverdriveBoard: use default resolution for GOP Ard Biesheuvel
2018-12-10 21:58 ` Leif Lindholm [this message]
2018-12-11 8:01 ` [PATCH edk2-platforms 0/6] Styx: fixes for IASL abuse and more Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210215823.nxk2z3qpqrcce63v@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox