From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C30421A07A80 for ; Mon, 10 Dec 2018 13:58:28 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id r24so7596138wmh.0 for ; Mon, 10 Dec 2018 13:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CzovV/67+0oNUplbEt3/G4/jwUJLKnIlkcbkdLFuHN4=; b=fTZcOqygGOAAnvT8wR5KoyhBWpLG7BmunklvIUOsDGGTsFBWFnXgA6tNErgDWv/imk fiAib3w+yxxgWEFvcM0wnXpF/9ysIbzKJjJ1ojSSvx+0cWPpxwVXQ6Hs/TSbs04CNIA0 9fLHiopE9pfIzmvmSkEoHgc4z/AP6DbIA9SW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CzovV/67+0oNUplbEt3/G4/jwUJLKnIlkcbkdLFuHN4=; b=X30mwdXj7Yia9iUTBckMdNgeD3+mI2JunOIxYpgnxcjtFVWINdPIDdfnegm5LFukk+ i9KX96UHwo38mmDN1K6/zEGDdazhl9mh/spmZJ/rb/4wKz8SrrLvX5OxQgeRyBUiLP0b X/joYpukk2QbJO0/jFNzPeAe6CEKkP7Z/j6KKF+olVDqk/IzWywpSGNVLlsvwihlnO+t nFQyiUrVUoJZYKFi2sKeqIJXQQa86YaNzsp+8r0WdroNVUMmktug6QLh64etXgRyiU1r q37NKuDzoDz2Nt/gns6gtgoNuwclBGA8m/hS2bcIiJqiB+UEjEq3zyPuDF5zeQxMJEyJ hUug== X-Gm-Message-State: AA+aEWbOG8nld1bSscj1lcOaSrboAOa13ZaxhTiwwF8RjkLgLsywfTrY rzxNZMhSD8JRB9ExHajdzqnIQ+NMMsM= X-Google-Smtp-Source: AFSGD/VIqoJO4IRPNEYRmDLKxxRAwOxKDrwOK9J1VpcRGWfM/3MBZicoM+7wTthZiXCLhKRBk1MZTw== X-Received: by 2002:a1c:c10f:: with SMTP id r15mr95060wmf.27.1544479105970; Mon, 10 Dec 2018 13:58:25 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e142sm273723wmf.46.2018.12.10.13.58.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 13:58:25 -0800 (PST) Date: Mon, 10 Dec 2018 21:58:23 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, alan@softiron.co.uk, graeme.gregory@linaro.org Message-ID: <20181210215823.nxk2z3qpqrcce63v@bivouac.eciton.net> References: <20181205185020.21441-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181205185020.21441-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 0/6] Styx: fixes for IASL abuse and more X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 21:58:28 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 05, 2018 at 07:50:14PM +0100, Ard Biesheuvel wrote: > Primarily, this series gets rid of the hacked up way this platform > patches the DSDT at build time, by #include'ing intermediate output > of the iasl compiler [or some version of it, at least] > > While at it, apply some other cleanups/improvements. All but the last one seem like they're following some form of common thread. But anyway: Reviewed-by: Leif Lindholm > Ard Biesheuvel (6): > Silicon/AMD/Styx: move SOC version macros to common header > Silicon/AMD/Styx: move B1 revision peripherals to separate SSDT table > Silicon/AMD/Styx: move XGBE declarations to separate SSDT table > Silicon/AMD/Styx: emit DSDT as aml directly > Platform: add acpiview to Seattle/Styx platforms > Platform/AMD/OverdriveBoard: use default resolution for GOP > > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 7 +- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 +- > .../Overdrive1000Board/Overdrive1000Board.dsc | 4 +- > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 2 +- > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 2 +- > .../Overdrive1000Board/Overdrive1000Board.fdf | 2 +- > Silicon/AMD/Styx/AcpiTables/AcpiAml.inf | 29 --- > Silicon/AMD/Styx/AcpiTables/AcpiTables.inf | 3 - > .../AcpiPlatformDxe/AcpiPlatformDxe.inf | 13 ++ > Silicon/AMD/Styx/Common/AmdStyxAcpiLib.h | 1 - > Silicon/AMD/Styx/Common/SocVersion.h | 19 ++ > Silicon/AMD/Styx/AcpiTables/Dsdt.c | 192 ------------------ > Silicon/AMD/Styx/AcpiTables/Iort.c | 6 +- > .../Drivers/AcpiPlatformDxe/AcpiPlatform.c | 137 ++++++++++++- > .../StyxSataPlatformDxe/InitController.c | 7 +- > .../StyxDtbLoaderLib/StyxDtbLoaderLib.c | 7 +- > .../AcpiPlatformDxe}/Dsdt.asl | 180 ---------------- > .../Styx/Drivers/AcpiPlatformDxe/SsdtB1.asl | 86 ++++++++ > .../Styx/Drivers/AcpiPlatformDxe/SsdtXgbe.asl | 135 ++++++++++++ > 19 files changed, 395 insertions(+), 442 deletions(-) > delete mode 100644 Silicon/AMD/Styx/AcpiTables/AcpiAml.inf > create mode 100644 Silicon/AMD/Styx/Common/SocVersion.h > delete mode 100644 Silicon/AMD/Styx/AcpiTables/Dsdt.c > rename Silicon/AMD/Styx/{AcpiTables => Drivers/AcpiPlatformDxe}/Dsdt.asl (72%) > create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtB1.asl > create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/SsdtXgbe.asl > > -- > 2.19.2 >