From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DF36421962301 for ; Mon, 10 Dec 2018 14:14:45 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id r11-v6so243525wmb.2 for ; Mon, 10 Dec 2018 14:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5H9e42g5ZDZ3BAUc0Q9ClohGa6YAeo+sLRG/jdVLSDk=; b=J1EHZ79w0n8gKP/6dlD2/GG3bmMhqbgSnnzHnjICyEJIZk1QcbNGzBuFFXETHYADcE FZ+SXRKZ9ITY5nAnkpSeJCxcPZF1dSQUIeyMT0dsFUXJV4AMRYyo/AB0S4FiXadDmBPA XLwst8LPjkjSwqjfnBm97GeBXD6GsJidEEv1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5H9e42g5ZDZ3BAUc0Q9ClohGa6YAeo+sLRG/jdVLSDk=; b=VDgTKaxQbTUuCHc4a/bXNHtKHMIm/7KqD11kONK+WH5jxQwadKaGUJxjthrmqIzsff i1ZFWy1aidC/v4qINWIsFSajqt+vG6DsCDMcX99fE8qUssBw22JkadbH/tQGqiKD97r4 F9PuUtg0qvseTn0od5SV/xWrP8LdnmG0ofKL8kJ1lkL7lr8ktX04Q+c2S16oJCRgxlMu 8lqO1HPVMhXGZUcBRjsTCp/FyWaQ69M/+YCfubSSz78zOhdMEchsQgiF5YHyaBuVqIXY 1PYBVzOI5mXIkCUbKZAk9Oi+F94TqkSDcutOcte5x8Sr/fezas1+wUqhCd4r3lyl/N+l c6UA== X-Gm-Message-State: AA+aEWZMw7yzjZgodmZV5fp/Ci9klAV4Ceo3hT1Cyl9s/KTGbuYCU6LK E1MNegF6wAYodxPFhRAeeNWHzsYz3iM= X-Google-Smtp-Source: AFSGD/U/yGpo3MYoipUNwx0cLfpb9QzulKTEOKzp0yrYDegFNPQlZHvt6mItRsxzIrOUmGyRvkR3Tg== X-Received: by 2002:a1c:4d12:: with SMTP id o18mr151987wmh.92.1544480084188; Mon, 10 Dec 2018 14:14:44 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l78sm19807737wma.0.2018.12.10.14.14.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 14:14:43 -0800 (PST) Date: Mon, 10 Dec 2018 22:14:41 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20181210221441.2xwqqzgafxpvqguu@bivouac.eciton.net> References: <20181205201049.10590-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181205201049.10590-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 22:14:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 05, 2018 at 09:10:48PM +0100, Ard Biesheuvel wrote: > The PCDs containing the default MAC addresses are of type UINT64, > and so the byte order needs to be inverted. As they are currently, > both default MAC addresses are invalid since they have the multicast > bit set. Ah, oops. That would also prevent them from being "locally administered" and hence permissible without registering an entry in the OUI. However, to reduce someone interpreting the _new_ values that way instead, could you do one of: - Adding a comment explaining these are in reverse byte order. or - Convert them to the new Array type PCD[1], to make the bytes appear in natural order? [1] edk2 72a1d77694d51914c0dd6aa97dbfa58634b0a4a5 / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 05433d4472e8..2843e51f93f7 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -469,8 +469,8 @@ DEFINE DO_CAPSULE = FALSE > gAmdModulePkgTokenSpaceGuid.PcdPort1NetSpeed|1 > > [PcdsDynamicDefault.common] > - gAmdStyxTokenSpaceGuid.PcdEthMacA|0x02A1A2A3A4A5 > - gAmdStyxTokenSpaceGuid.PcdEthMacB|0x02B1B2B3B4B5 > + gAmdStyxTokenSpaceGuid.PcdEthMacA|0xA5A4A3A2A102 > + gAmdStyxTokenSpaceGuid.PcdEthMacB|0xB5B4B3B2B102 > > [PcdsPatchableInModule] > gAmdModulePkgTokenSpaceGuid.PcdXgbeUseMacFromIscp|TRUE > -- > 2.19.2 >