From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D48382119175F for ; Mon, 10 Dec 2018 14:20:38 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id p4so12102685wrt.7 for ; Mon, 10 Dec 2018 14:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BoYEaTX1X+XQpOcM2DyHL3OzwWxPn/+InWHECtu4sCc=; b=NQNXGd9h2C66CU2mz44PNlNKn7pdRkXqSAFP24xNUtZhtBgKkZsg2aFxt60JI9RsN3 li8jsU0AVcJji3NusYgqSa/d/fwtBqQn67DBm6or1rUsy/OQsuqQAWzyiRZuKJwthiFU fWGQ+nsFwY9O3Z1aIfhi8nsyILgqDB9ynxs3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BoYEaTX1X+XQpOcM2DyHL3OzwWxPn/+InWHECtu4sCc=; b=f6HUFQ4fASMu0WWBUoIPH3E4nghTRHI12NvwOflJwshdyQD4+OCwTyb5rm+hjb7LBC 6cyU83LjZlymyWbK9y11OkGPfuYUNcsUvuIIl0TSCCuazjO7528jR0g9xwZ2m23ujtLn I/9jWB9qG8i71Ryd0YsP0EV2X1oQHWVYlx97oa66hncEx2dkBF9DcZFFxzDtN8yJFmV7 /3l5x+TuNmbR0DsLpLK+RQvDG0dJVukvgp5Hl93UTmUHyR8rw7ewa6clZMLeaTswDV+N nUbCamkqo2Dv2ccs+ShSssZZsj0yNdt+MH+WKWcR65nZTPGSueaxyOhexRDJAiikTmu1 OQcA== X-Gm-Message-State: AA+aEWYafYAewiSqd9FUV11TX+zD7087Zt2ikDEYMcj7qYeuuzQ0XG2R RCLrOoa3/boQqe6Ac9S/mrsvJq68ztc= X-Google-Smtp-Source: AFSGD/VGKCDkyWqLNwPYuAe0ENgyGrh2W2HbO0B/mpg0eKbcB5oXBWG0ZyfYYeSvSDkztF0O76Ly3w== X-Received: by 2002:adf:f605:: with SMTP id t5mr10673599wrp.229.1544480436527; Mon, 10 Dec 2018 14:20:36 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p5sm164920wmh.16.2018.12.10.14.20.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 14:20:35 -0800 (PST) Date: Mon, 10 Dec 2018 22:20:34 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, alan@softiron.co.uk, graeme.gregory@linaro.org Message-ID: <20181210222034.rsfuzb7cac26br4m@bivouac.eciton.net> References: <20181206121204.4057-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181206121204.4057-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 0/2] Silicon/Styx: merge and simplify ACPI platform driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 22:20:39 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 06, 2018 at 01:12:02PM +0100, Ard Biesheuvel wrote: > After fixing the iasl issue yesterday, I got a bit carried away and ended > up rewriting most of the ACPI table generation logic for Styx. So this > applies on top of the patches I sent out yesterday. > > Patch #1 merges the DXE driver and the library, that are split in two for > no good reason. > > Patch #2 simplifies the MADT generation code. I would be lying if I said I'd properly reviewed this series, but superficially it looks good, and I trust you to have tested it properly. So: Reviewed-by: Leif Lindholm > Ard Biesheuvel (2): > Silicon/AMD/Styx: merge ACPI table drivers > Silicon/Styx/AcpiPlatformDxe: simplify MADT generation logic > > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 1 - > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 - > .../Overdrive1000Board/Overdrive1000Board.dsc | 1 - > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 1 + > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 1 + > .../Overdrive1000Board/Overdrive1000Board.fdf | 1 + > Silicon/AMD/Styx/AcpiTables/AcpiTables.inf | 85 ----- > .../AcpiPlatformDxe/AcpiPlatformDxe.inf | 34 +- > .../AcpiPlatformDxe/AcpiPlatform.h} | 11 +- > Silicon/AMD/Styx/AcpiTables/Madt.c | 318 ------------------ > .../Drivers/AcpiPlatformDxe/AcpiPlatform.c | 155 +++++---- > .../AcpiPlatformDxe/Csrt.aslc} | 13 +- > .../AcpiPlatformDxe/Dbg2.aslc} | 12 +- > .../AcpiPlatformDxe/Fadt.aslc} | 11 +- > .../AcpiPlatformDxe/Gtdt.aslc} | 20 +- > .../AcpiPlatformDxe/Iort.aslc} | 19 +- > .../Styx/Drivers/AcpiPlatformDxe/Madt.aslc | 117 +++++++ > .../AcpiPlatformDxe/Mcfg.aslc} | 13 +- > .../AcpiPlatformDxe/Pptt.aslc} | 10 +- > .../AcpiPlatformDxe/Spcr.aslc} | 12 +- > 20 files changed, 264 insertions(+), 572 deletions(-) > delete mode 100644 Silicon/AMD/Styx/AcpiTables/AcpiTables.inf > rename Silicon/AMD/Styx/{Common/AmdStyxAcpiLib.h => Drivers/AcpiPlatformDxe/AcpiPlatform.h} (81%) > delete mode 100644 Silicon/AMD/Styx/AcpiTables/Madt.c > rename Silicon/AMD/Styx/{AcpiTables/Csrt.c => Drivers/AcpiPlatformDxe/Csrt.aslc} (93%) > rename Silicon/AMD/Styx/{AcpiTables/Dbg2.c => Drivers/AcpiPlatformDxe/Dbg2.aslc} (95%) > rename Silicon/AMD/Styx/{AcpiTables/Fadt.c => Drivers/AcpiPlatformDxe/Fadt.aslc} (96%) > rename Silicon/AMD/Styx/{AcpiTables/Gtdt.c => Drivers/AcpiPlatformDxe/Gtdt.aslc} (92%) > rename Silicon/AMD/Styx/{AcpiTables/Iort.c => Drivers/AcpiPlatformDxe/Iort.aslc} (95%) > create mode 100644 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Madt.aslc > rename Silicon/AMD/Styx/{AcpiTables/Mcfg.c => Drivers/AcpiPlatformDxe/Mcfg.aslc} (86%) > rename Silicon/AMD/Styx/{AcpiTables/Pptt.c => Drivers/AcpiPlatformDxe/Pptt.aslc} (97%) > rename Silicon/AMD/Styx/{AcpiTables/Spcr.c => Drivers/AcpiPlatformDxe/Spcr.aslc} (90%) > > -- > 2.19.2 >