From: Leif Lindholm <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org,
nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com,
kostap@marvell.com
Subject: Re: [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h
Date: Tue, 11 Dec 2018 13:39:26 +0000 [thread overview]
Message-ID: <20181211133926.qsa4n3wic7krecuv@bivouac.eciton.net> (raw)
In-Reply-To: <1544534315-30714-1-git-send-email-mw@semihalf.com>
On Tue, Dec 11, 2018 at 02:18:35PM +0100, Marcin Wojtas wrote:
> Recent changes in EDK2 resulted in compilation break
> of all Marvell platforms, because the applications
> include deprecated ShellBase.h header. Fix that.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 852195e6f5.
Thanks for quick turnaround!
> ---
> Silicon/Marvell/Applications/EepromCmd/EepromCmd.c | 1 -
> Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c | 1 -
> Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
> index f43e411..dc3c95f 100644
> --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
> +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
> @@ -34,7 +34,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> #include <Uefi.h>
>
> -#include <ShellBase.h>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> diff --git a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
> index 9ccb1c7..22a9b8f 100644
> --- a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
> +++ b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
> @@ -31,7 +31,6 @@ ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> *******************************************************************************/
> -#include <ShellBase.h>
> #include <Uefi.h>
>
> #include <Library/BaseLib.h>
> diff --git a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
> index cf91581..a028c54 100644
> --- a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
> +++ b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
> @@ -32,7 +32,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> *******************************************************************************/
> #include <Uefi.h>
> -#include <ShellBase.h>
>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> --
> 2.7.4
>
prev parent reply other threads:[~2018-12-11 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 13:18 [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h Marcin Wojtas
2018-12-11 13:39 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211133926.qsa4n3wic7krecuv@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox