From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 187AD21A143EF for ; Tue, 11 Dec 2018 05:39:30 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id q26so2272042wmf.5 for ; Tue, 11 Dec 2018 05:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sMxby3Jn8luzmkfQgd7dpBXkyYxn7UeqvbNXCHKkgj4=; b=cKoRURfGFtTkrfge11Z3ZY3he02JBoW9tqgKL/srGIqhkll9K3ZIvroc+JUbo+uyhs p+AOpNhQkVO3m6FQGgYWo8fO26LhN2GgRtx5JWjInfmr14DTVMJ8OBgCMMAD25wwlMth PJ/KO3Fijpglg4Crn+c+3WCb8vKUux3TUc0ek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sMxby3Jn8luzmkfQgd7dpBXkyYxn7UeqvbNXCHKkgj4=; b=aDamDTpLze/eZF84R3Jrj4gMlAruLSZP7iKEAz8+KR3G1dHwhJV+b1SzNeZTmmXSOG lJLo7cbuK/fZUyQuF6+M3Lz9TceQ6rkgtAKktPlwtCmU4KuAoUige1Ku/HOo6/iitDst e/8O+NUvEdUoxsqkiB1YIAFZaP9ElMwAJpysVLNpujgH0S+BeN7PAf60aZZ6Mcl319jq cwR/JM7/XPTONrfr7W5yf37+GY/EvrBtpTyR8OQXMziHD6ez8i2PRmoM4nshzgPQNoHO q+vSBPONSLuki6cen++DM0c1caZs5nJP3qQLsNNMKPFJrsBnfFFc7fkLWYH+ojOy+sIY gzHA== X-Gm-Message-State: AA+aEWZYxTLpXrYodEjHkweciERYv61GdpOHvUd456CoQlg6h1ni7cc5 pOiSnEijSaepWAbiXCLCxuljUw== X-Google-Smtp-Source: AFSGD/UcLD5EbDgSbucprC5sjvlM7M9xu+W1CQORPkqt5fj3FMTWYdnJiZoNGSn0a9hTOyZn2Ti4QA== X-Received: by 2002:a1c:8acd:: with SMTP id m196mr2408876wmd.120.1544535569200; Tue, 11 Dec 2018 05:39:29 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d4sm14163240wrp.89.2018.12.11.05.39.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Dec 2018 05:39:28 -0800 (PST) Date: Tue, 11 Dec 2018 13:39:26 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20181211133926.qsa4n3wic7krecuv@bivouac.eciton.net> References: <1544534315-30714-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1544534315-30714-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 13:39:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 11, 2018 at 02:18:35PM +0100, Marcin Wojtas wrote: > Recent changes in EDK2 resulted in compilation break > of all Marvell platforms, because the applications > include deprecated ShellBase.h header. Fix that. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm Pushed as 852195e6f5. Thanks for quick turnaround! > --- > Silicon/Marvell/Applications/EepromCmd/EepromCmd.c | 1 - > Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c | 1 - > Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c > index f43e411..dc3c95f 100644 > --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c > +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c > @@ -34,7 +34,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > #include > > -#include > #include > #include > #include > diff --git a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c > index 9ccb1c7..22a9b8f 100644 > --- a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c > +++ b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c > @@ -31,7 +31,6 @@ ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > *******************************************************************************/ > -#include > #include > > #include > diff --git a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c > index cf91581..a028c54 100644 > --- a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c > +++ b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c > @@ -32,7 +32,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > *******************************************************************************/ > #include > -#include > > #include > #include > -- > 2.7.4 >